Re: [PUSHED] java cleanup patches

2012-08-29 Thread Stephan Bergmann
On 08/28/2012 04:24 PM, Noel Grandin wrote: The change to Job.java was OK, because 3 lines up we had already checked the exception field for null, so it was not possible for it to be null at that point. Ach, of course. Didn't look closely enough. Pushed now, too. Stephan

Re: [PUSHED] java cleanup patches

2012-08-28 Thread Noel Grandin
On 2012-08-28 16:16, Stephan Bergmann wrote: On 08/27/2012 01:43 PM, Noel Grandin wrote: These patches remove various bits of dead code, and perform some mild cleanup. The change to jurt/com/sun/star/lib/uno/environments/remote/Job.java in 0006 was unsound. The rest looked good. Thanks.

Re: [PUSHED] java cleanup patches

2012-08-28 Thread Stephan Bergmann
On 08/27/2012 01:43 PM, Noel Grandin wrote: These patches remove various bits of dead code, and perform some mild cleanup. The change to jurt/com/sun/star/lib/uno/environments/remote/Job.java in 0006 was unsound. The rest looked good. Stephan ___