Re: [PUSHED] Some fixes for Clang warnings

2012-04-25 Thread Stephan Bergmann
On 04/24/2012 11:26 PM, Catalin Iacob wrote: I attached updated patches which use SAL_WARN_IF instead of OSL_ENSURE, warnings are indeed gone and hopefully the messages are a bit better than before. The 3rd one links to the CLucene patch proposed upstream as you suggested. Pushed all three now

Re: [PUSHED] Some fixes for Clang warnings

2012-04-24 Thread Catalin Iacob
On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann wrote: > Only 0002-WaE-Clang-unused-variable.patch and > 0003-WaE-Clang-unused-variable.patch I did not push.  Can you change them as > I suggested above (or just let me know if you want me to do that)? I attached updated patches which use SAL_WAR

Re: [PUSHED] Some fixes for Clang warnings

2012-04-24 Thread Stephan Bergmann
On 04/23/2012 11:20 PM, Lubos Lunak wrote: Note that I do not get any crash with the test2.cc test file with "SUSE Linux clang version 3.1 (trunk 154660) (based on LLVM 3.1svn)", nor I see any other compiler crash during LO compile, so you might want to upgrade first. (My test2.cc only causes

Re: [PUSHED] Some fixes for Clang warnings

2012-04-23 Thread Lubos Lunak
On Monday 23 of April 2012, Catalin Iacob wrote: > The plan is also to report the Clang crash that I encountered, I can > report your test too while I'm at it if I can reproduce it (didn't try > yet) and then keep going, as time allows, with Clang + werror and see > what else turns out. Note that

Re: [PUSHED] Some fixes for Clang warnings

2012-04-23 Thread Catalin Iacob
On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann wrote: > Pushed most of these now: > 0001-WaE-Clang-empty-forloop-body.patch: trivially fixed tabs to spaces Sorry for that, the file doesn't have mode declarations for Emacs like they usually do, probably because it's a ll file. > 0005-WaE-Clang

Re: [PUSHED] Some fixes for Clang warnings

2012-04-23 Thread Stephan Bergmann
On 04/23/2012 01:24 PM, Stephan Bergmann wrote: diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx index 47ca98f..23d4871 100644 --- a/cppu/source/uno/lbenv.cxx +++ b/cppu/source/uno/lbenv.cxx @@ -987,7 +987,7 @@ inline void EnvironmentsData::registerEnvironment( uno_Environment *