Re: [PUSHED] adding calc add-in for option pricing

On Wed, 2012-12-05 at 10:21 +0100, Stephan Bergmann wrote: > (I would have preferred not to fiddle with .src files post > feature-freeze, but it looks like that FUNCDATA macro ties those various > names together, and this hopefully does not affect anything already > translated anyway.)

Re: [PUSHED] adding calc add-in for option pricing

On 12/04/2012 06:40 PM, tino wrote: I've attached a patch to sort out the internal UNO variable/function naming issue. ...which I pushed now to master and libreoffice-4-0, with the slight modification of keeping the parameter names in XPricingFunctions.idl lowercase. (I would have preferred

Re: [PUSHED] adding calc add-in for option pricing

> > Do I also have to change the function name exported to the cell, e.g. > > OPT_BARRIER()? > > My concern here would be that potentially calc function naming is not > always a great match to UNO constraints - and yet those functions are > defined as IDL. Some functions have '.'s in them II

Re: [PUSHED] adding calc add-in for option pricing

On Tue, 2012-12-04 at 15:01 +, tino wrote: > Do I also have to change the function name exported to the cell, e.g. > OPT_BARRIER()? My concern here would be that potentially calc function naming is not always a great match to UNO constraints - and yet those functions are defined as ID

Re: [PUSHED] adding calc add-in for option pricing

On 12/04/2012 04:21 PM, Eike Rathke wrote: On Tuesday, 2012-12-04 14:32:36 +0100, Stephan Bergmann wrote: Eike, my vague understaning of Calc Add-Ins is that they indeed need both a new UNO service and interface definition, right? Yes, the scaddins/idl/com/sun/star/sheet/addin/{PricingFunction

Re: [PUSHED] adding calc add-in for option pricing

Hi, On Tuesday, 2012-12-04 14:32:36 +0100, Stephan Bergmann wrote: > Eike, my vague understaning of Calc Add-Ins is that they indeed need > both a new UNO service and interface definition, right? Yes, the scaddins/idl/com/sun/star/sheet/addin/{PricingFunctions.idl,XPricingFunctions.idl} are fine

Re: [PUSHED] adding calc add-in for option pricing

On 12/04/2012 04:01 PM, tino wrote: Do you mean function names like getOpt_barrier() or input variables as put_call or both? If it's the function names then would getOpt_barrier() --> getOptBarrier() be ok? Ah, right, some parameter names are affected, too. So yes, please replace all identifie

Re: [PUSHED] adding calc add-in for option pricing

> >Do you mean function names like getOpt_barrier() or input variables as > >put_call or both? If it's the function names then would > >getOpt_barrier() --> getOptBarrier() be ok? > > Ah, right, some parameter names are affected, too. So yes, please > replace all identifiers containing underscore

Re: [PUSHED] adding calc add-in for option pricing

On 12/04/2012 02:52 PM, tino wrote: Seeing this commit, I note that XPricingFunctions has method identifiers starting with a lower case letter and containing underscores. Such identifiers are reserved to the UNO implementation. (See . T

Re: [PUSHED] adding calc add-in for option pricing

> Seeing this commit, I note that XPricingFunctions has method > identifiers starting with a lower case letter and containing > underscores. Such identifiers are reserved to the UNO > implementation. (See > . There Sorry, UNO has been to

Re: [PUSHED] adding calc add-in for option pricing

On 12/04/2012 01:23 PM, Fridrich Strba (via Code Review) wrote: Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1232 Approvals: Fridrich Strba: Verified; Looks good to me, approved Seeing

[PUSHED] adding calc add-in for option pricing

Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1232 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1232 To unsubscribe,