Re: [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-02 Thread Thorsten Behrens
José Guilherme Vanz wrote: > 2012/10/1 Thorsten Behrens > > partially pushed - I left the hunks commenting empty methods as > > FIXME instead of removing them straight away unapplied. If the > > method is pointless, why not remove them in one go? > > > Hi José Guilherme, want to go ahead & kill t

Re: [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-02 Thread José Guilherme Vanz
Hi! I unterstood... Thanks for comment! I'll do more and better next time :-) 2012/10/1 Thorsten Behrens > guilherme@gmail.com wrote: > > This patch removes '@author' annotation, code in comments > > and adjust some empty catches. It's cleanup patch > > > Hi José Guilherme, > > partially p

Re: [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-02 Thread Michael Meeks
On Tue, 2012-10-02 at 10:54 +0200, Stephan Bergmann wrote: > On 10/01/2012 08:03 PM, Thorsten Behrens wrote: > > I also did not apply your printStackTrace() logging calls, I think > > at least some of them report on exceptions that were seemingly > > previously ignored on purpose? > > > > Stephan,

Re: [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-02 Thread Stephan Bergmann
On 10/01/2012 08:03 PM, Thorsten Behrens wrote: I also did not apply your printStackTrace() logging calls, I think at least some of them report on exceptions that were seemingly previously ignored on purpose? Stephan, or anyone else more up-to-date with contemporary java idiom, any opinions here

[PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

2012-10-01 Thread Thorsten Behrens
guilherme@gmail.com wrote: > This patch removes '@author' annotation, code in comments > and adjust some empty catches. It's cleanup patch > Hi José Guilherme, partially pushed - I left the hunks commenting empty methods as FIXME instead of removing them straight away unapplied. If the method