Re: [PUSHED][PATCH] Remove unused code (oox)

2012-04-10 Thread Caolán McNamara
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Yup, pushed now. Well, actually Julien removed the same code and got in first. C. ___ LibreOffice mailing list LibreOffice@lists.

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-29 Thread Caolán McNamara
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote: > Hi there, > > removed unused methods pushed, thanks for these C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Petr Vorel
> FWIW, if a class has only one constructor and that constructor is unused > then it indicates that the whole class (except perhaps for any static > methods it might have) should be possible to be removed. Sorry, I'll think more next time. Petr ___ LibreO

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-28 Thread Caolán McNamara
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote: > Hi there, > > yet another remove unused code patch. Pushed now, thanks for this. FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-27 Thread Caolán McNamara
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote: > Hi there, > > another bits of unused code removed. looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [PUSHED][PATCH] remove unused code (oox)

2012-03-26 Thread Caolán McNamara
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote: > Hi there, > > removed some code from oox. Pushed, looks good. I suspect that this will have a bit of a cascade effect and a pile more stuff will become available for removal on the next run. C. __

Re: [PUSHED][PATCH] remove unused code (oox, sc)

2012-03-20 Thread Caolán McNamara
On Sun, 2012-03-18 at 14:40 +0100, Petr Vorel wrote: > Hi there, > > some unused code removed (oox, sc). Looks good to me, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mai