Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-06 Thread Chr. Rossmanith
Am 06.02.2012 11:50, schrieb Ivan Timofeev: On 06.02.2012 13:34, Chr. Rossmanith wrote: I have replaced parameter ResData *pResData (which became ununsed) with parameter rtl::OString sTextType. Or should it be rtl::OString& sTextType instead? A reference is better, however it is not really per

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-06 Thread Ivan Timofeev
On 06.02.2012 13:34, Chr. Rossmanith wrote: I have replaced parameter ResData *pResData (which became ununsed) with parameter rtl::OString sTextType. Or should it be rtl::OString& sTextType instead? A reference is better, however it is not really performance-critical I think. But if so, refere

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-06 Thread Chr. Rossmanith
Hi again, The following string concatenation argument have to be passed as a parameter as well. +if ( pResData->bText ) +sOutput += pResData->sTextTyp; +else if ( pResData->bQuickHelpText ) +sOutput += "QuickHelpText"; +else

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-06 Thread Ivan Timofeev
06.02.2012 00:13, Chr. Rossmanith пишет: I've added a third parameter nType to ResData2Output() (s. reworked attached patch) The following string concatenation argument have to be passed as a parameter as well. +if ( pResData->bText ) +sOutput += pResData->sTextTy

Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith
Am 05.02.2012 20:52, schrieb Ivan Timofeev: 05.02.2012 23:37, Chr. Rossmanith пишет: I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... Oh, oh, oh! No, we must pass all the different values as paramerers to the function. I'v