Hey!
I aam sure the mentor at that point in time initially when i started my
work on the LO codebase...he asked me to do the same ,and that is why i
made the following changes
But yeah if you still feel i need to change the patch according with the
buffer thing resolved,ill do it and mail it to
Janit Anjaria wrote:
> I am hereby attaching my patch on fdo#57950 where the .append() calls are
> replaced by + operator.
>
Hi Janit,
this does not seem to be a patch against master - the code there has
OUStringBuffer sBuffer etc etc, not OUString sBuffer as required by
your patch. Please squas
Hey!
I am hereby attaching my patch on fdo#57950 where the .append() calls are
replaced by + operator.
Regards,
Janit
On Tue, Apr 9, 2013 at 7:00 PM, Janit Anjaria wrote:
> Hey Thorsten!
> As a mentor it would be great if you review my bug and tell me if i need
> to further make any kinda c
Hey Thorsten,
I am not pretty sure how can that be possible but yes i would clean the
patch up and then mail it .
Regards,
Janit
On Tue, Apr 9, 2013 at 4:02 AM, Thorsten Behrens wrote:
> Janit Anjaria wrote:
> > I am hereby submitting my patch for review on the bug/feature which
> > i had work
Janit Anjaria wrote:
> I am hereby submitting my patch for review on the bug/feature which
> i had worked long back which replaces all the .append() calls witha
> + operator.
>
Hi Janit,
thanks for that patch - it needs some cleanup, too, though. String
literals can be appended without explicit O
Hey!
I am hereby submitting my patch for review on the bug/feature which i had
worked long back which replaces all the .append() calls witha + operator.
Regards,
Janit
0001-fdo-57950-replace-chained-O-U-StringBuffer-append-wi.patch
Description: Binary data
__
