Re: [PATCH] various .ui fixes caught by linter tool

2013-03-18 Thread Jack Leigh
On 18/03/13 11:45, Michael Meeks wrote: On Mon, 2013-03-18 at 12:01 +0100, Lubos Lunak wrote: On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: various .ui fixes caught by linter tool Sounds really interesting :-) can we make the tool part of our build process som

Re: [PATCH] various .ui fixes caught by linter tool

2013-03-18 Thread Michael Meeks
On Mon, 2013-03-18 at 12:01 +0100, Lubos Lunak wrote: > > On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: > > > various .ui fixes caught by linter tool > > > > Sounds really interesting :-) can we make the tool part of our build > > process somehow ? > > And do we need

Re: [PATCH] various .ui fixes caught by linter tool

2013-03-18 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Em 18-03-2013 08:01, Lubos Lunak escreveu: > And do we need such a tool at all? If Glade is not capable of providing > sensible defaults for spacing and similar features, cannot our code for > loading the .ui files handle that? Glade will not d

Re: [PATCH] various .ui fixes caught by linter tool

2013-03-18 Thread Lubos Lunak
On Saturday 16 of March 2013, Michael Meeks wrote: > Hi Jack, > > On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: > > various .ui fixes caught by linter tool > > Sounds really interesting :-) can we make the tool part of our build > process somehow ? And do we need su

Re: [PATCH] various .ui fixes caught by linter tool

2013-03-16 Thread Jack Leigh
On 16/03/13 17:51, Michael Meeks wrote: Hi Jack, On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: various .ui fixes caught by linter tool Sounds really interesting :-) can we make the tool part of our build process somehow ? That was my aim at some point. It's

Re: [PATCH] various .ui fixes caught by linter tool

2013-03-16 Thread Michael Meeks
Hi Jack, On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: > various .ui fixes caught by linter tool Sounds really interesting :-) can we make the tool part of our build process somehow ? ATB, Michael. -- michael.me...@suse.com <><, Pseudo

[PATCH] various .ui fixes caught by linter tool

2013-03-15 Thread Jack Leigh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2763 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2763/1 various .ui fixes caught by linter tool Change-Id: Ic92ddc9550b33358a3bb0458b31a23f2c32fd46f --- M cui/uiconfig/