Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-18 Thread Kohei Yoshida
Hi there, On Tue, 2012-04-17 at 14:31 +0200, Noel Grandin wrote: > This patch passes "make sc.subsequentcheck". Just to add a cautionary note, IIRC much of the chart functionality is not covered by our test framework. So, use caution when modifying this part of the code, and I would appreciate a

[PUSHED] Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-18 Thread Michael Stahl
On 17/04/12 14:31, Noel Grandin wrote: > And here is the second patch in the series. > > This patch actually converts chart2uno.cxx from tools/table.hxx to std::map > > This was the last file using tools/table in the LO tree. > > This patch passes "make sc.subsequentcheck". great, pushed both p

Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-17 Thread Noel Grandin
And here is the second patch in the series. This patch actually converts chart2uno.cxx from tools/table.hxx to std::map This was the last file using tools/table in the LO tree. This patch passes "make sc.subsequentcheck". (I can't do a check on the full tree because the build still has linking

[PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-16 Thread Noel Grandin
Hi Patch is against master, and my license statement is on file. This is a precursor patch to converting from tools/table.hxx usage to std::map Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Remove-unnecessary-auto_ptr-complexity.patch Description: applicat