On 09.02.2012 21:38, Ivan Timofeev wrote:
Another question is why in the code above there is
pVScrollbar->IsVisible(sal_False)
for the vertical scrollbar. I don't know. If this condition is true,
then the right border should be set:
rToFill.Right() = nTmp;
But even if you move that line to the ou
On Thu, 2012-02-09 at 21:38 +0400, Ivan Timofeev wrote:
> Hi,
>
> actually there was not a scrollbar appearing at the bottom, there was a
> border. :)
...
> so in normal mode we use IsVisible(false), that checks for
> SwScrollbar::bVisible, regardless of the real visibility. The next line:
>
Hi,
actually there was not a scrollbar appearing at the bottom, there was a
border. :)
The root cause lives in sw/source/ui/uiview/viewport.cxx,
SwView::CalcAndSetBorderPixel.
The code is:
//#i32913# in browse mode the visibility of the horizontal scrollbar
// depends on the content
Hi Caolán,
30.01.2012 21:08, Caolán McNamara пишет:
The original code with...
git show 7b0b5cdf source/ui/inc/scroll.hxx source/ui/uiview/scroll.cxx
it seems that this SwScrollbar had its own SwScrollbar::Show method and
inherits from Window which has a Window::Show method as well. The
Window::S
On Sun, 2012-01-29 at 15:01 +0400, Ivan Timofeev wrote:
> what is the reason to have this flag? Why only set this flag without
> actually showing? And why not change this flag accordingly when actually
> showing? (This is what the patch fixes.)
Digging into the git history it looks like a collec
n Sep 17 00:00:00 2001
From: Ivan Timofeev
Date: Sun, 29 Jan 2012 14:08:54 +0400
Subject: [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty
horizontal scrollbar
---
sw/source/ui/uiview/scroll.cxx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sw/source/
