On Sat, Apr 14, 2012 at 12:12 PM, julien2412 wrote:
> Hi Kohei,
>
> First thank you for your support.
> I commited and pushed the fix on master, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=95cc5de63b20c5986fe8f3913da86002eabd7cb1
>
> I removed the 3 "delete" + moved the line you
f I didn't misunderstand what you said on the thread, it mustn't and can't
be applied on 3.5 branch so no need to ask review for this.
Anyway thank you again.
Julien.
--
View this message in context:
http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-48683-tp3910199p3910415.html
Hi Julien,
On Sat, Apr 14, 2012 at 11:08 AM, Kohei Yoshida wrote:
> I did refactor this part, and now the text portion container manages
> the life cycle of stored containers. There is no need to delete
> stored elements outside of it. So, you did the right thing here.
While you are at it, th
Hi Julien,
On Sat, Apr 14, 2012 at 9:59 AM, julien2412 wrote:
> I can commit and push on master of course but I'd like first your opinion
> about this since I could missed something.
Yup, your fix is right on. Please push to master.
I did refactor this part, and now the text portion container
D_LINEBREAK )
{
TextPortion* pNext = pParaPortion->GetTextPortions()[
nPortion ];
I can commit and push on master of course but I'd like first your opinion
about this since I could missed something.
Julien.
--
View this message in context:
http://nabble.docum
