On Fri, Jun 15, 2012 at 10:54 PM, Caolán McNamara wrote:
> What we could do with is the addition of a regression test for my
> fdo#50141 error where we lost the char count for the
> bullet/numbering :-). SwDoc::SetNumRule might be useful in setting some
> numbering directly on some part of a SwDoc
On Fri, 2012-06-15 at 18:55 +0200, Muhammad Haggag wrote:
> If you do add it yourself, please share the commit
I added it myself because I'd already started before I read your mail
http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a59c7096cde0ced1a88069647c3ec60f86f9d6
I checked that the
Hi there,
On Fri, 2012-06-15 at 18:55 +0200, Muhammad Haggag wrote:
> Thanks for pushing the patch. I can add the regression test myself if
> you give me a couple of pointers; e.g. where to add it, or the source
> of a similar test. If you do add it yourself, please share the commit
> so that I ca
On Fri, Jun 15, 2012 at 5:37 PM, Caolán McNamara wrote:
>
> Definitely was bogus count before fix, and correct count afterwards.
> Pushed to master now. Sorry for delay. I should cook up a regression
> test for this.
>
Thanks for pushing the patch. I can add the regression test myself if
you give
On Wed, 2012-06-13 at 16:55 +0200, Muhammad Haggag wrote:
> We were ignoring redlined (deleted) text when counting characters, but
> not when counting words or characters without spaces. We now mask all
> redlined/hidden content from the expanded node text before operating on
> it.
Definitely was
= Bug =
https://bugs.freedesktop.org/show_bug.cgi?id=46757
= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=62967
= Patch Review =
https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=46757&attachment=62967
= Changes =
We were ignoring redlined (deleted) text when counting charact
