Re: [PUSHED] Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-07 Thread Jan Holesovsky
Hi Tomaž, On 2012-06-06 at 23:22 +0200, Tomaž Vajngerl wrote: > > Great stuff - I have pushed your patch, and also my patches to default > > to Lanczos filter. Can you please add an example of "before" and > > "after" where the advantages of the Lanzcos filter are nicely visible to > > the Relea

Re: [PUSHED] Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-06 Thread Tomaž Vajngerl
Hi, On Tue, Jun 5, 2012 at 11:33 AM, Jan Holesovsky wrote: > Great stuff - I have pushed your patch, and also my patches to default > to Lanczos filter.  Can you please add an example of "before" and > "after" where the advantages of the Lanzcos filter are nicely visible to > the Release Notes (h

[PUSHED] Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-05 Thread Jan Holesovsky
Hi Tomaz, On 2012-06-05 at 07:34 +0200, Tomaž Vajngerl wrote: > I found the problem - rescaling did not work correctly when upscaling > the image. I don't see any artifacts with this fix anymore when I use > Lanczos for all scale operations. Great stuff - I have pushed your patch, and also my pa

Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-04 Thread Tomaž Vajngerl
Hi, I found the problem - rescaling did not work correctly when upscaling the image. I don't see any artifacts with this fix anymore when I use Lanczos for all scale operations. Best regards, Tomaž Vajngerl 0001-Lanczos-resampling-mirror-image-on-edges-and-fix-ima.patch Description: Binary data

Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-04 Thread Quikee
Hi Jan, On Mon, Jun 4, 2012 at 4:50 PM, Jan Holesovsky wrote: > - changed sal_Bool -> bool (we prefer the native bool in the new code) I used what other code around was using. If bool is preferred to sal_Bool maybe the whole bitmap and bitmapex code should be changed to reflect this. I can do th

Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

2012-06-04 Thread Jan Holesovsky
Hi again, On 2012-06-04 at 16:50 +0200, Jan Holesovsky wrote: > I've pushed that to master And - please can you confirm that the license of your work is according to the project's needs? Ideally if you can send a license statement to this mailing list stating "All of my past & future contribut

[PATCH] fdo#46378: Poor Resampling Image quality

2012-06-03 Thread Quikee
Hi, I implemented Lanczos resampling for bug fdo#46378. Lanczos resampling is a lot better than currently available resampling methods (FAST and INTERPOLATE). Currently the lanczos resampling is only enabled for PDF export. The patch is attached to this mail and to the bugzilla report. Best rega