Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Markus Mohrhard
Hello Artur, I finally reviewed the patch and found several compiler errors. Can you please next time compile before submitting a patch. You would have immediately see that there are still errors in the patch and that the test would have never passed. You find the corrected patch at http://cgit.f

Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Markus Mohrhard
Hey Miklos, > On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda > wrote: >> This patch is transferring XPrintAreas test to c++, from >> qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/ > > Great! > >> Though not all tests are transferred, I'm sending this so it could be >> re

Re: [PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-17 Thread Miklos Vajna
Hi Artur, On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda wrote: > This patch is transferring XPrintAreas test to c++, from > qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/ Great! > Though not all tests are transferred, I'm sending this so it could be > reviewed, becaus

[PATCH] fdo#45904: [EasyHack] move java based api tests to c++

2012-04-14 Thread Artur Dorda
Hello, This patch is transferring XPrintAreas test to c++, from qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/ Though not all tests are transferred, I'm sending this so it could be reviewed, because it's my first patch and changes 5 files. Best regards, Artur Dorda 0001-transf