Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-06-19 Thread Stephan Bergmann
s not much useful anyway; the strip still safes something Jun 19 17:22:16 pmladek, yes, found your reply to "[PATCH] fdo#39643: Remove --disable-strip-solver configure option" thread now where you explicitly add -strip for .archive Jun 19 17:22:23 LibreOffice-Libreoffice normal/medium

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-26 Thread Petr Mladek
Petr Mladek píše v Čt 26. 04. 2012 v 10:59 +0200: > I am going to double check it in a clean build and push it within next 3 > hours or so. It needed slightly more tweaking, see the attached patch. 1. I used "--strip" instead of "-strip" in ooinstall. There already was "--help" and it was more ty

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-26 Thread Petr Mladek
Hello David, David Ostrovsky píše v Čt 26. 04. 2012 v 08:07 +0200: > thank you for your review and your comments. > Here is a new version with these issues fixed: > > 1. no strip in solenv/bin/deliver.pl any more > 2. solenv/bin/modules/installer preserves striping code > 3. there is a new target

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-25 Thread David Ostrovsky
__ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice >From 860462c53c8e33e77b57db0e693e508b0b39f40d Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Wed, 25 Apr 2012 21:29:28 +0200 Subject:

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-25 Thread Petr Mladek
d.ostrov...@idaia.de píše v Út 24. 04. 2012 v 11:33 +0200: > Do we agree about to drop the striping code from ooinstaller? What do you mean by ooinstaller? Just the single ooinstall script or also also the solenv/bin/modules/installer/* stuff? It is hard to say until we know what is the benefit o

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Michael Meeks
On Tue, 2012-04-24 at 10:32 +0200, Petr Mladek wrote: > > strip removes the table of internal symbols. The effect is that > > backtrace information (whether produced by LO's unmaintained automatic > > crash reporting or manually by a capable user) becomes hard to use (or > > even next to usele

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread d . ostrovsky
Zitat von Lubos Lunak : On Tuesday 24 of April 2012, Stephan Bergmann wrote: On 04/23/2012 06:17 PM, Petr Mladek wrote: > I am not sure but I think that strip reduces size of binaries even when > you build without -g. It just removes something less important. strip removes the table of interna

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Stephan Bergmann wrote: > On 04/23/2012 06:17 PM, Petr Mladek wrote: > > I am not sure but I think that strip reduces size of binaries even when > > you build without -g. It just removes something less important. > > strip removes the table of internal symbols. The eff

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Petr Mladek
Stephan Bergmann píše v Út 24. 04. 2012 v 09:00 +0200: > On 04/23/2012 06:17 PM, Petr Mladek wrote: > > I am not sure but I think that strip reduces size of binaries even when > > you build without -g. It just removes something less important. > > strip removes the table of internal symbols. The

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Stephan Bergmann
On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the table of internal symbols. The effect is that backtrace information (whether produced by LO's un

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-23 Thread Petr Mladek
Lubos Lunak píše v Po 23. 04. 2012 v 13:37 +0200: > On Monday 23 of April 2012, Petr Mladek wrote: > > Hmm, we might want to keep the strip stuff and the -dontstrip options in > > the in the perl installer. It is handy when you have debug build and you > > need to send someone the small stripped bu

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-23 Thread Bjoern Michaelsen
On Mon, Apr 23, 2012 at 01:37:29PM +0200, Lubos Lunak wrote: > On Monday 23 of April 2012, Petr Mladek wrote: > > Hmm, we might want to keep the strip stuff and the -dontstrip options in > > the in the perl installer. It is handy when you have debug build and you > > need to send someone the small

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-23 Thread Lubos Lunak
On Monday 23 of April 2012, Petr Mladek wrote: > Hmm, we might want to keep the strip stuff and the -dontstrip options in > the in the perl installer. It is handy when you have debug build and you > need to send someone the small stripped build. It is a big difference in > the size. I am not sure i

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-23 Thread Petr Mladek
Hi David, thanks a lot for looking at it. Your patch is almost perfect. Well, there are still some open questions, see below. :-) David Ostrovsky píše v So 21. 04. 2012 v 14:23 +0200: > Hi, > > here is the patch to remove strip solver configure option. > Some places still has a strip code, for e

[PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-21 Thread David Ostrovsky
; if ($^O eq 'cygwin'); [...] was not sure if it is still needed. Note: I've tested make dev-install only on Linux. Ciao David >From ee90882e30d4ef9c60ea81018286cbfc8b07b566 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Wed, 18 Apr 2012 22:31:41 +0200 Subject: [PATCH] fdo#39643: R