Re: [PUSHED][PATCH] fdo#38828: Save position of tab dialogs

2012-06-26 Thread Caolán McNamara
On Mon, 2012-06-25 at 18:49 -0500, Travis Carter wrote: > I've sent a message to the mailing list. I'll add myself to the > developers list once the archives refresh. Great. So I pushed this now. > Keeping it in the dtor and adding it to ::Ok sounds alright to me. Fair enough. > ... Should I ro

Re: [PATCH] fdo#38828: Save position of tab dialogs

2012-06-25 Thread Travis Carter
> Looks good. So... > > First up, can you add yourself to > http://wiki.documentfoundation.org/Development/Developers and link to a > mail that states that your submission is under our preferred MPL/LGPLv3+ > license combo. Most seem to go for a simple "all my patches unless I say > otherwise" > >

Re: [PATCH] fdo#38828: Save position of tab dialogs

2012-06-25 Thread Caolán McNamara
On Thu, 2012-06-21 at 20:03 -0500, Travis Carter wrote: > I've already submitted a patch that isn't as well formed to the bug > listing. Sorry. This was my first patch to any project and I should > have checked a little better on the preferred submission method. The > one attached here should be be

[PATCH] fdo#38828: Save position of tab dialogs

2012-06-21 Thread Travis Carter
I've already submitted a patch that isn't as well formed to the bug listing. Sorry. This was my first patch to any project and I should have checked a little better on the preferred submission method. The one attached here should be better. 0001-Properly-store-dialog-s-position-and-current-page.p