Re: [PUSHED][PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Noel Grandin
On Tue, Feb 21, 2012 at 18:06, Ivan Timofeev wrote: > Could you prepare your future patches using 'git format-patch', please? > Will do! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreof

Re: [PUSHED][PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Ivan Timofeev
On 21.02.2012 15:09, Noel Grandin wrote: Thanks, that was just the suggestion I needed! Converted patch to use boost:ptr_map. Great! Pushed, thanks for it. Could you prepare your future patches using 'git format-patch', please? Best Regards, Ivan __

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-21 Thread Noel Grandin
Hi Thanks, that was just the suggestion I needed! Converted patch to use boost:ptr_map. Regards, Noel Grandin On 2012-02-20 17:17, Ivan Timofeev wrote: On 20.02.2012 19:12, Noel Grandin wrote: The error was sourced several levels down in the boost stuff, and the originating point was everyw

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Ivan Timofeev
On 20.02.2012 19:12, Noel Grandin wrote: The error was sourced several levels down in the boost stuff, and the originating point was everywhere I tried to assign into ptr_map. I think it had something to with the copyability of the Font class. Did you try to use 'insert(key, value)' instead of

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Noel Grandin
On Mon, Feb 20, 2012 at 16:38, Ivan Timofeev wrote: > Hi Noel, > > > What line produces that error? I suppose we should do use ptr_map, because > even you forgot to delete object :) The error was sourced several levels down in the boost stuff, and the originating point was everywhere I tried to a

Re: [PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-20 Thread Ivan Timofeev
Hi Noel, On 14.02.2012 15:25, Noel Grandin wrote: Note that I tried converting these usages to boost::ptr_map, but I ran into entirely undecipherable C++ template errors. Sorry for the late review... :( What line produces that error? I suppose we should do use ptr_map, because even you forgo

[PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-14 Thread Noel Grandin
Hi License statement already on file. "make check" succeeds. Note that I tried converting these usages to boost::ptr_map, but I ran into entirely undecipherable C++ template errors. (can't wait for template-type-checking aka. concepts to make it into the language). Regards, Noel Grandin D