[PUSHED] Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-25 Thread Michael Stahl
On 24/04/12 19:41, Noel Grandin wrote: > On Tue, Apr 24, 2012 at 19:03, Michael Stahl wrote: >> >> so the first patch, which Caolan already pushed, causes a segfault in >> dbaccess_complex, because of a double free in >> SwXTextView::removeSelectionChangeListener: the >> boost::ptr_vector::erase()

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Stephan Bergmann
On 04/24/2012 07:03 PM, Michael Stahl wrote: it would of course be nice if the f..ine documentation would mention that erase() will delete the element, but i can't find that fact mentioned here: http://www.boost.org/doc/libs/1_49_0/libs/ptr_container/doc/ptr_sequence_adapter.html It kind of im

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Noel Grandin
On Tue, Apr 24, 2012 at 19:03, Michael Stahl wrote: > > so the first patch, which Caolan already pushed, causes a segfault in > dbaccess_complex, because of a double free in > SwXTextView::removeSelectionChangeListener: the > boost::ptr_vector::erase() actually deletes the element. > Aaaargh. I sh

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Michael Stahl
On 24/04/12 08:56, Noel Grandin wrote: > Hi > > This series of patches converts various datastructures in the SW module > from SV*PTRARR to std::vector, std::set, and boost::ptr_set variously. so the first patch, which Caolan already pushed, causes a segfault in dbaccess_complex, because of a do