Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Ivan Timofeev
05.02.2012 23:37, Chr. Rossmanith пишет: I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... Oh, oh, oh! No, we must pass all the different values as paramerers to the function. Because it was if ( pEntry && pResData->bText

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith
Hi, I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... > bWriteNoSlash seems to be always false I'll add this to the patch and wait until I get feed back wrt the test question (s. below) before I'll push. Yes. And ByteStri

Re: [PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Ivan Timofeev
Hi Christina, 05.02.2012 20:26, Chr. Rossmanith пишет: there were three blocks of nearly identical code. Awful! Thanks for working on this task. I've moved them to a method ResData2Output(). Please review. Looks nice. All of the differences seem to be handled... > bWriteNoSlash seems to b

[PATCH] Reduced duplicate code (simian) / l10ntools

2012-02-05 Thread Chr. Rossmanith
:00:00 2001 From: Christina Rossmanith Date: Sun, 5 Feb 2012 15:03:30 +0100 Subject: [PATCH] Reduced duplicate code (simian) / l10ntools --- l10ntools/inc/export.hxx|2 +- l10ntools/source/export.cxx | 222 --- 2 files changed, 81 insertions(+), 14