Re: [PUSHED] [PATCH] Object Catalog in Dialog Editor

2012-08-24 Thread Noel Power
Bah, I meant to reply to this but got hung up with something else and forgot On 21/08/12 17:33, János Uray wrote: the Layout class has some virtual methods with no implementation, this sounds like these need to be pure virtual making Layout an abstract class ( which makes sense ) Whe

Re: [PUSHED] [PATCH] Object Catalog in Dialog Editor

2012-08-21 Thread János Uray
> the Layout class has some virtual methods with no implementation, this > sounds like these need to be pure virtual making Layout an abstract class ( > which makes sense ) When I looked a little close at some of those methods I > notice > IMO, not all empty virtual functions need to be pure virtua

Re: [PUSHED] [PATCH] Object Catalog in Dialog Editor

2012-08-17 Thread Noel Power
Hi János On 17/08/12 09:49, Noel Power wrote: Anyway I think if this runs ok ( I will try it later ) I would be inclined to just check it in, the benefits from this change far outweigh any new minor bugs that might be introduced. I will attempt to review or at least scan the resulting new code

Re: [PATCH] Object Catalog in Dialog Editor

2012-08-17 Thread Noel Power
Hi János you have official become my personal hero On 17/08/12 06:59, János Uray wrote: Now in Basic IDE, the Object Catalog window is not only visible in the basic editor, but also in the dialog editor. The same window can be docked in both. perfect There was a ModulWindowLayout class that ha