Re: [PUSHED][PATCH] Kill VbaFontBase::get/setUnderline

2012-04-10 Thread Caolán McNamara
On Tue, 2012-04-10 at 09:43 +0200, Miklos Vajna wrote: > On Sat, Apr 07, 2012 at 09:15:30PM +0200, Gábor Stefanik > wrote: > > > Hm, are you sure this is right, without removing the > > > Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply > > > removing an attribute from there m

Re: [PATCH] Kill VbaFontBase::get/setUnderline

2012-04-10 Thread Miklos Vajna
On Sat, Apr 07, 2012 at 09:15:30PM +0200, Gábor Stefanik wrote: > > Hm, are you sure this is right, without removing the > > Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply > > removing an attribute from there may break the ABI, I'm not sure.) > > It definitely does compile

Re: [PATCH] Kill VbaFontBase::get/setUnderline

2012-04-07 Thread Gábor Stefanik
On Sat, Apr 7, 2012 at 8:36 PM, Miklos Vajna wrote: > Hi Gábor, > > On Sat, Apr 07, 2012 at 07:30:42PM +0200, Gábor Stefanik > wrote: >> Unused code removal. > > Hm, are you sure this is right, without removing the > Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply > removing

Re: [PATCH] Kill VbaFontBase::get/setUnderline

2012-04-07 Thread Miklos Vajna
Hi Gábor, On Sat, Apr 07, 2012 at 07:30:42PM +0200, Gábor Stefanik wrote: > Unused code removal. Hm, are you sure this is right, without removing the Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply removing an attribute from there may break the ABI, I'm not sure.) > Signed

[PATCH] Kill VbaFontBase::get/setUnderline

2012-04-07 Thread Gábor Stefanik
Unused code removal. Signed-off-by: Gábor Stefanik 0001-Kill-vbaFontBase-get-setUnderline.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice