Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-19 Thread Keith Curtis
HI Kendy, Thank you! I've pulled your diff and doing a rebuild now. I have found that 5 pixels is a good value on my machine but I'll try 6, and it needs to be shifted down one more pixel. Also, there may be dirt because it increases the waveheight after the check. I believe Linux will return 96 d

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-19 Thread Jan Holesovsky
Hi Keith, Keith Curtis píše v Pá 13. 12. 2013 v 15:58 -0500: > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to > get an API first as I'm just writing "if (1) //hidpi". So

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-18 Thread Keith Curtis
Hi Kendy, I had no idea to where to put this so I appreciate your help. I verified your idea works for all of the places I worked on so far because it can get to a Window. If there were static constructors that loaded and cached shared bitmaps, I think it could be a problem, but the earliest I've

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-18 Thread Jan Holesovsky
Hi Keith, Keith Curtis píše v Pá 13. 12. 2013 v 15:58 -0500: > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to > get an API first as I'm just writing "if (1) //hidpi". I

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-13 Thread Keith Curtis
Unfortunately, there is no resolution-independent back-end as the interface from LibreOffice to the OS is in discrete pixels and it has made extensive use of that ubiquitous design. I agree for user-created objects such as arrows and such, things should be defined in terms of resolution-independen

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-13 Thread Tomaž Vajngerl
Hi, On Fri, Dec 13, 2013 at 9:58 PM, Keith Curtis wrote: > Hi Kendy, > > Good to hear from you. I've got a number of things in progress on my > computer beyond the underlines > (https://wiki.documentfoundation.org/Development/HiDpi) but I wait to get an > API first as I'm just writing "if (1) //h

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-13 Thread Keith Curtis
Hi Kendy, Good to hear from you. I've got a number of things in progress on my computer beyond the underlines ( https://wiki.documentfoundation.org/Development/HiDpi) but I wait to get an API first as I'm just writing "if (1) //hidpi". I personally don't think a floating point value is a good ide

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-13 Thread Jan Holesovsky
Hi Keith, Keith Curtis píše v Po 09. 12. 2013 v 19:36 -0500: > LibreOffice looks good on a HiDPI screens but there are a few small > bugs such as (fdo#51735) > > So I'm working on fixing the squiggly underlines. Patch included below. First of all, thank you so much for the patches you have subm

Re: [PATCH] HiDPI fixes for squiggly underlines

2013-12-11 Thread Keith Curtis
I wanted to follow up with the underline issue clipping code below and send a new patch. I have looked again at the code and did more testing. I started by commenting out the check again and was able to see problems so I can say that code is sometimes still important. But it doesn't appear to need

[PATCH] HiDPI fixes for squiggly underlines

2013-12-09 Thread Keith Curtis
Hi; LibreOffice looks good on a HiDPI screens but there are a few small bugs such as (fdo#51735) So I'm working on fixing the squiggly underlines. Patch included below. Instead of drawing them one pixel wide and 3 pixels tall as the code does today, what looks great is 2 pixels wide and 5 pixels