Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-25 Thread Michael Meeks
On Sat, 2012-06-23 at 22:12 +0200, Cor Nouws wrote: > Ah well, my memory was wrong. But apparently some change in the dialog > container code saved me: the 3.6.0 beta produces a higher dialog on > Windows :-) Great :-) > So I can forget my initial thoughts about rearrangements.

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-23 Thread Cor Nouws
Cor Nouws wrote (19-06-12 18:51) I'm also slightly amazed you managed to find vertical space in that dialog to cram that thing into; did you test with the worst-case setup there of tons of those options being visible ? IIRC that happens on Windows. Since I'm not building on Windows, it's no

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-19 Thread Cor Nouws
Michael Meeks wrote (19-06-12 12:28) So - it's good to have the patch included :-) However, it should be noted that by submitting this patch you (and Olivier?) are morally volunteering ;-) to fix any macro recording / playback bugs that get filed ;-) There is a reason that the f

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-19 Thread Michael Meeks
On Mon, 2012-06-18 at 07:53 +0200, Cor Nouws wrote: > > Incidentally - if you want to get this into 3.6 as a late feature you > > need to be drumming up support for another 2x reviews quickly ;-) - we > > want to get that lot in by Monday. > > Ah, if possible, that would be nice. > I see a +

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-18 Thread Cor Nouws
Hi Michael, all, Michael Meeks wrote (15-06-12 19:17) On Sun, 2012-06-10 at 23:07 +0200, Cor Nouws wrote: See fdo#41865 Incidentally - if you want to get this into 3.6 as a late feature you need to be drumming up support for another 2x reviews quickly ;-) - we want to get that lot in

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-15 Thread Olivier Hallot
for what it worth: +1 to push it for 3.6 [?] Regards Olivier 2012/6/15 Michael Meeks > Hi Cor, > > On Sun, 2012-06-10 at 23:07 +0200, Cor Nouws wrote: > > See fdo#41865 > >Incidentally - if you want to get this into 3.6 as a late feature > you > need to be drumming up support for anot

Re: [PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-15 Thread Michael Meeks
Hi Cor, On Sun, 2012-06-10 at 23:07 +0200, Cor Nouws wrote: > See fdo#41865 Incidentally - if you want to get this into 3.6 as a late feature you need to be drumming up support for another 2x reviews quickly ;-) - we want to get that lot in by Monday. Having said that - it's a pl

[PATCH] Give Macro recorder separate option, apart from Experimental features

2012-06-10 Thread Cor Nouws
Hi, See fdo#41865 The patch does work, however the value is not saved to (read from) registrymodifications.xcu Maybe this is related to the fact that #define PROPERTYCOUNT 11 has been removed from svtools/source/config/miscopt.cxx ? (It been deleted with this commit http://opengrok.libreof