Re: [PATCH] Introduce SAL_DELETE

2012-12-11 Thread Lubos Lunak
On Tuesday 11 of December 2012, Noel Grandin wrote: > Maybe give it a more explicit name? > Without looking, it's not clear at all what the macro does. > > Perhaps > SAL_DELETE_MEMBER > or > SAL_CPP11_DELETE > ?? Good point. Pushed SAL_DELETED_FUNCTION. -- Lubos Lunak l.lu...@suse.cz

Re: [PATCH] Introduce SAL_DELETE

2012-12-11 Thread Michael Meeks
On Tue, 2012-12-11 at 17:16 +0200, Noel Grandin wrote: > Maybe give it a more explicit name? > Without looking, it's not clear at all what the macro does. Just reading the name I thought: nice, this is a consolidated macro to kill all the 'DELETEZ' variants around the place ;-) S

Re: [PATCH] Introduce SAL_DELETE

2012-12-11 Thread Noel Grandin
Maybe give it a more explicit name? Without looking, it's not clear at all what the macro does. Perhaps SAL_DELETE_MEMBER or SAL_CPP11_DELETE ?? On 2012-12-11 17:00, Stephan Bergmann (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1299 To

[PATCH] Introduce SAL_DELETE

2012-12-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1299 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1299/1 Introduce SAL_DELETE Change-Id: I7ac7392646ea34fb2e6a9f15990aca05a2c1e484 --- M sal/inc/rtl/ustrbuf.hxx M sal/in