Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Radek Doulik
On Mon, 2012-02-13 at 18:08 +0100, Lionel Elie Mamane wrote: > On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote: > > > looks OK to me. I have cherry-picked it from master, because the > > attached patch didn't apply. > > Oh, sorry, some difference between my work tree and pristine > l

Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Lionel Elie Mamane
On Mon, Feb 13, 2012 at 05:39:51PM +0100, Radek Doulik wrote: > looks OK to me. I have cherry-picked it from master, because the > attached patch didn't apply. Oh, sorry, some difference between my work tree and pristine libreoffice-3-5 must have made a mess. The "sorted by concatenation" proble

Re: [PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-13 Thread Radek Doulik
Hi, looks OK to me. I have cherry-picked it from master, because the attached patch didn't apply. Pushed. Thanks. Cheers Radek On Thu, 2012-02-09 at 19:27 +0100, Lionel Elie Mamane wrote: > getColumns() is a XDatabaseMetadata interface function to get the list > of columns of a table and info o

[PATCH] [REVIEW:3-5] PostgreSQL getColumns()

2012-02-09 Thread Lionel Elie Mamane
getColumns() is a XDatabaseMetadata interface function to get the list of columns of a table and info on these columns. The PostgreSQL-SDBC implementation in 3.5.0 has a couple of bugs fixed by the attached patch. - If the table previously had a column that has since been dropped (removed),