Re: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread Matúš Kukan
On 13 April 2012 15:58, David Ostrovsky wrote: > > Hi Matúš, > > this patch should fix the missing key in hash on Macos build [1]: > > illegal combination app/SDKBIN/URELIB at > /Volumes/TBRAM/core/solenv/bin/macosx-change-install-names.pl line 70, > line 2. Nice catch, I think it will help, p

Fwd: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread David Ostrovsky
build LO wth idlc converted? Thanks David [1] http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1334322010.10061 Original Message Subject: Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed Date: Fri, 13

Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread Stephan Bergmann
On 04/13/2012 01:39 PM, Matúš Kukan wrote: On 13 April 2012 12:56, David Ostrovsky wrote: Here is the corrected patch. I fixed the build error with --enable-werror option enabled. Hmm, I would not push it together. Warning errors are somehow related to gbuild because there are different setti

Re: [PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread David Ostrovsky
Hej Matúš, you don't have to be scared, just push it ;-) here is warning fix as a seperate patch. David On 13.04.2012 13:39, Matúš Kukan wrote: On 13 April 2012 12:56, David Ostrovsky wrote: Hi, Here is the corrected patch. I fixed the build error with --enable-werror option enabled. Hmm,

[PUSHED] Re: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread Matúš Kukan
On 13 April 2012 12:56, David Ostrovsky wrote: > Hi, > > Here is the corrected patch. > I fixed the build error with --enable-werror option enabled. Hmm, I would not push it together. Warning errors are somehow related to gbuild because there are different settings but I would push that separatel

[PUSHED] Re: [PATCH][REVIEW] gbuild conversion: idlc module

2012-04-13 Thread Matúš Kukan
Hi David On 12 April 2012 23:45, David Ostrovsky wrote: > > thank you for your comments on my patch. I changed it accordingly. nice patch, thanks I pushed it with few modifications: - removed new_style from CustomTarget - also removed makefile.mk from inc/ - and please, could you be consistent

Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- build problems fixed

2012-04-13 Thread David Ostrovsky
Original Message Subject: Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- problem with --enable-werror Date: Fri, 13 Apr 2012 11:26:03 +0200 From: David Ostrovsky To: Libreoffice-dev Hi, my patch (that is apparently not pushed yet ;-) breaks the build with

Re: Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- problem with --enable-werror

2012-04-13 Thread Stephan Bergmann
On 04/13/2012 11:26 AM, David Ostrovsky wrote: C++ error is about bison generated parser: idlc/source/parser.y:261:13: Fehler: #pragma system_header außerhalb include-Datei ignoriert [-Werror] source/parser.y: In Funktion »int yyparse()«: source/parser.y:604:65: Fehler: Um Zuweisung, die als Wah

Fwd: Re: [PATCH][REVIEW] gbuild conversion: idlc module -- problem with --enable-werror

2012-04-13 Thread David Ostrovsky
MSC" APP1STDLIBS=gnu_getopt.lib .ELIF "$(GUI)$(COM)" == "WNTGCC" APP1STDLIBS=-lgnu_getopt .ENDIF .ENDIF Having said that, how could we simplify the gnu_getopt treatment in tools/Executable_rscdep.mk? David ---- Original Message Subject:Re: [PATCH][REVIEW]

Re: [PATCH][REVIEW] gbuild conversion: idlc module

2012-04-12 Thread David Ostrovsky
at, how could we simplify the gnu_getopt treatment in tools/Executable_rscdep.mk? David ---- Original Message ---- Subject:Re: [PATCH][REVIEW] gbuild conversion: idlc module Date: Thu, 12 Apr 2012 06:33:19 +0200 From: David Tardon To: David Ostrovsky CC: Libreoffice-dev

Re: [PATCH][REVIEW] gbuild conversion: idlc module

2012-04-12 Thread Matúš Kukan
Hi David, On 11 April 2012 23:18, David Ostrovsky wrote: > this is gbuild conversion for idlc module. nice > We don't have lexer function for gbuild, so I converted dmake stuff directly > in CustomTarget_scanner.mk. With http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a45deba2be4a77d

Re: [PATCH][REVIEW] gbuild conversion: idlc module

2012-04-11 Thread Matúš Kukan
On 12 April 2012 06:33, David Tardon wrote: > Originally idlc is linked with salhelper too. It is possible it is no > longer necessary, but it is also possible that it is necessary on a > different platform. salhelper is often needed only for Windows. > ifeq ($(HAVE_GETOPT),YES) > > # nothing ne

Re: [PATCH][REVIEW] gbuild conversion: idlc module

2012-04-11 Thread David Tardon
On Wed, Apr 11, 2012 at 11:18:46PM +0200, David Ostrovsky wrote: > Hi, > > this is gbuild conversion for idlc module. Good. But it is not quite ready yet, see comments below. > diff --git a/Repository.mk b/Repository.mk > index 1a3851e..638f4f8 100644 > --- a/Repository.mk > +++ b/Repository.mk

[PATCH][REVIEW] gbuild conversion: idlc module

2012-04-11 Thread David Ostrovsky
Hi, this is gbuild conversion for idlc module. We don't have lexer function for gbuild, so I converted dmake stuff directly in CustomTarget_scanner.mk. @Matus, thank you for your help on IRC with that. If we have more lexer stuff it would be nice to see a convenience function gb_Executable_ad