On 18/03/2013 09:07, Lionel Elie Mamane wrote:
Lionel, could this point explain these logs I had put in
https://bugs.freedesktop.org/show_bug.cgi?id=61725#c7) :
warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369:
ODsnTypeCollection::implDetermineType : missing the second colon !
w
On Mon, Mar 11, 2013 at 05:47:19AM -0700, julien2412 wrote:
> Lionel, could this point explain these logs I had put in
> https://bugs.freedesktop.org/show_bug.cgi?id=61725#c7) :
> warn:legacy.osl:22802:1:dbaccess/source/core/misc/dsntypes.cxx:369:
> ODsnTypeCollection::implDetermineType : missing
I've corrected it to equals. Thanks Stephan for spotting this!
Thomas
Am 11.03.2013 13:48, schrieb Stephan Bergmann:
On 03/11/2013 12:56 PM, Lionel Elie Mamane wrote:
So,
compareToAscii never returned zero
means
url.compareToAscii(..) == 0 never was true
so you are saying that
return bEn
On 03/11/2013 12:56 PM, Lionel Elie Mamane wrote:
So,
compareToAscii never returned zero
means
url.compareToAscii(..) == 0 never was true
so you are saying that
return bEnabled &&
url.compareToAscii("sdbc:embedded:hsqldb",sizeof("sdbc:embedded:hsqldb")) == 0
was in fact equivalent to
re
Lionel Elie Mamane wrote
> Thanks Stephan, good catch!
>
> Short version: this was, and should remain, an equality test and not a
> "string begins with, but can continue with anything" test.
> ...
Lionel, could this point explain these logs I had put in
https://bugs.freedesktop.org/show_bug.cgi?i
Thanks Stephan, good catch!
Short version: this was, and should remain, an equality test and not a
"string begins with, but can continue with anything" test.
On Mon, Mar 11, 2013 at 12:05:40PM +0100, Stephan Bergmann wrote:
> On 03/11/2013 11:10 AM, Thomas Arnhold wrote:
> >commit 937b63af3322f7f
On 03/11/2013 11:10 AM, Thomas Arnhold wrote:
commit 937b63af3322f7f8b5e869b2c7431a2deaec3113
Author: Thomas Arnhold
Date: Sat Mar 9 22:47:20 2013 +0100
use startsWith() instead of compareToAscii()
brain damage...
Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
[...]
d