Re: [Libreoffice-commits] core.git: 2 commits - reportdesign/source svx/source

2013-11-08 Thread Lionel Elie Mamane
On Fri, Nov 08, 2013 at 11:09:03AM +0100, Stephan Bergmann wrote: > On 11/08/2013 10:09 AM, Lionel Elie Mamane wrote: > >On Fri, Nov 08, 2013 at 08:57:31AM +0100, Stephan Bergmann wrote: >>> Would it not be better here to change >>> OShape::getSupportedServiceNames instead, to also report >>> m_sS

Re: [Libreoffice-commits] core.git: 2 commits - reportdesign/source svx/source

2013-11-08 Thread Stephan Bergmann
On 11/08/2013 10:09 AM, Lionel Elie Mamane wrote: On Fri, Nov 08, 2013 at 08:57:31AM +0100, Stephan Bergmann wrote: Would it not be better here to change OShape::getSupportedServiceNames instead, to also report m_sServiceName? On the face of it, it sounds reasonable. I tried to do it with the

Re: [Libreoffice-commits] core.git: 2 commits - reportdesign/source svx/source

2013-11-08 Thread Lionel Elie Mamane
On Fri, Nov 08, 2013 at 08:57:31AM +0100, Stephan Bergmann wrote: > Ouch. I must admit I at least didn't carefully inspect all of the > supportsService implementations cleaned up in > "Adapt > supportsService implementations to cppu::supportsSer

Re: [Libreoffice-commits] core.git: 2 commits - reportdesign/source svx/source

2013-11-07 Thread Stephan Bergmann
Ouch. I must admit I at least didn't carefully inspect all of the supportsService implementations cleaned up in "Adapt supportsService implementations to cppu::supportsService" for this gotcha of deliberate incompatibility between supportsSe

[Libreoffice-commits] core.git: 2 commits - reportdesign/source svx/source

2013-11-07 Thread Lionel Elie Mamane
reportdesign/source/core/api/Shape.cxx |2 +- svx/source/unodraw/unoshap4.cxx|9 - 2 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 3cc85b071fdcf75adf8bcb3d59984940395c81e1 Author: Lionel Elie Mamane Date: Fri Nov 8 03:08:10 2013 +0100 earlier f