Re: [Libreoffice] vcl/unx: remove duplicate printer code

2010-12-17 Thread Caolán McNamara
On Fri, 2010-12-17 at 14:25 +0100, Joachim wrote: > If I look at the different create_SalInstance functions, there is always > an instance of xxxSalInstance. Right? There should be, right. That's my understanding. > So we can move the the PrinterUpdate code in the xxxSalInstances > classes, kee

Re: [Libreoffice] vcl/unx: remove duplicate printer code

2010-12-17 Thread Joachim
On 12/17/2010 11:22 AM, Caolán McNamara wrote: On Wed, 2010-12-15 at 19:58 +0100, Joachim wrote: - The following removed methods were not strictly identical to the existing: BOOL PspSalInfoPrinter::Setup( SalFrame* pFrame, ImplJobSetup* pJobSetup ) void vcl_sal::PrinterUpdate::doUpdate() void v

Re: [Libreoffice] vcl/unx: remove duplicate printer code

2010-12-17 Thread Caolán McNamara
On Wed, 2010-12-15 at 19:58 +0100, Joachim wrote: > Hi, > > I have found some duplicate classes between vcl/unx and > vcl/unx/headless; PspSalInfoPrinter and PspSalPrinter. > As suggested by Caolàn, the attached patch removes these two classes > from vcl/unx/headless > > - The following removed

[Libreoffice] vcl/unx: remove duplicate printer code

2010-12-15 Thread Joachim
Hi, I have found some duplicate classes between vcl/unx and vcl/unx/headless; PspSalInfoPrinter and PspSalPrinter. As suggested by Caolàn, the attached patch removes these two classes from vcl/unx/headless - The following removed methods were not strictly identical to the existing: BOOL Psp