Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-09 Thread Kohei Yoshida
On Mon, 2011-05-09 at 14:27 +0200, Fridrich Strba wrote: > On Fri, 2011-05-06 at 18:55 +0200, Thorsten Behrens wrote: > > so, finally got to the bottom of this - patches attached. I feel > > *slightly* worried about pushing > > 0001-Fix-non-changeability-of-UI-locale.patch to -3-4 - the second > >

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-09 Thread Fridrich Strba
On Fri, 2011-05-06 at 18:55 +0200, Thorsten Behrens wrote: > so, finally got to the bottom of this - patches attached. I feel > *slightly* worried about pushing > 0001-Fix-non-changeability-of-UI-locale.patch to -3-4 - the second > hunk has some potential to cause loops, so review appreciated. >

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-07 Thread Kohei Yoshida
On Fri, 2011-05-06 at 18:55 +0200, Thorsten Behrens wrote: > so, finally got to the bottom of this - patches attached. I feel > *slightly* worried about pushing > 0001-Fix-non-changeability-of-UI-locale.patch to -3-4 - the second > hunk has some potential to cause loops, so review appreciated. It

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-07 Thread Andras Timar
2011/5/7 Thorsten Behrens : > You got me there - that indeed sounds almost impossible to work > around. So then, let's standardize on en-US, and make that a > required locale. > > Any opinion on whether to push the stuff to -3-4 already? If it works reliably, then please push. I don't see theoreti

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-07 Thread Thorsten Behrens
Kohei Yoshida wrote: > Well, if we can't assume a locale being set (regardless of whether or > not it's en-US), we wouldn't be able to test e.g. calculations involving > functions since all function names are localized. > Well, we could use translated names as input - granted, that sounds like much

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-06 Thread Kohei Yoshida
On Fri, 2011-05-06 at 18:55 +0200, Thorsten Behrens wrote: > Generally, and going forward - I'd be a bit happier if unit tests > would not assume en-US locale at all, since at least in theory, it's > possible to do a build w/o en-US at all... Well, if we can't assume a locale being set (regardles

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-06 Thread Thorsten Behrens
Kohei Yoshida wrote: > > This unit test expects that the UI is in English. Two English strings > > are hard coded into this test: Sum and Total. > > So, I looked into this this morning in hopes of finding a way to set UI > locale to en-US explicitly. > > http://cgit.freedesktop.org/libreoffice/ca

Re: [Libreoffice] testDataPilot unit test breaks in sc

2011-05-03 Thread Kohei Yoshida
On Mon, 2011-05-02 at 16:08 +0200, Andras Timar wrote: > This unit test expects that the UI is in English. Two English strings > are hard coded into this test: Sum and Total. So, I looked into this this morning in hopes of finding a way to set UI locale to en-US explicitly. http://cgit.freedeskt

[Libreoffice] testDataPilot unit test breaks in sc

2011-05-02 Thread Andras Timar
Hi, Expected: Sum - Score Actual: जोड़ - Score ucalc.cxx:868:Assertion Test name: N12_GLOBAL__N_14TestE::testDataPilot assertion failed - Expression: false - Unexpected cell content. Many of us have seen this. But it is still a problem in libreoffice-3-4 with all langs co