On Mon, 2011-08-29 at 20:49 +0200, Stephan Bergmann wrote:
> Zero. But it does not hurt that much to have them exported, does it?
> So I would just play it safe. YMMV.
Culturally - I think we prefer to play it dangerously - just on
principle :-) Having clean code is huge win vs. a very
On Aug 29, 2011, at 8:35 PM, Caolán McNamara wrote:
> On Mon, 2011-08-29 at 15:53 +0200, Stephan Bergmann wrote:
>> On Aug 29, 2011, at 2:50 PM, Matúš Kukan wrote:
>>> rtl_hashfunc, rtl_hashentry_destroy and 5 more rtl_hashtable_* from
>>> rtl/source/locale.c
>>
>> Ah, I see. Yes, indeed, appears
On Mon, 2011-08-29 at 15:53 +0200, Stephan Bergmann wrote:
> On Aug 29, 2011, at 2:50 PM, Matúš Kukan wrote:
> > rtl_hashfunc, rtl_hashentry_destroy and 5 more rtl_hashtable_* from
> > rtl/source/locale.c
>
> Ah, I see. Yes, indeed, appears they have erroneously been added to
> sal.map once, and
On Aug 29, 2011, at 2:50 PM, Matúš Kukan wrote:
> On 29 August 2011 09:48, Stephan Bergmann
> wrote:
>> On Aug 28, 2011, at 11:57 PM, Matúš Kukan wrote:
>>> I was working on gbuildizing sal and few problems showed up:
>>>
>>> 1, in sal/osl/unx/system.h:75 there is #if GLIBC >= 2
>>>but I coul
On 29 August 2011 09:48, Stephan Bergmann
wrote:
> On Aug 28, 2011, at 11:57 PM, Matúš Kukan wrote:
>> I was working on gbuildizing sal and few problems showed up:
>>
>> 1, in sal/osl/unx/system.h:75 there is #if GLIBC >= 2
>> but I could not find how is GLIBC defined. In Env.Host.sh I have
>>
On Mon, Aug 29, 2011 at 09:48:29AM +0200, Stephan Bergmann wrote:
> On Aug 28, 2011, at 11:57 PM, Matúš Kukan wrote:
> > I was working on gbuildizing sal and few problems showed up:
> >
> > 1, in sal/osl/unx/system.h:75 there is #if GLIBC >= 2
> >but I could not find how is GLIBC defined. In E
On Sun, 2011-08-28 at 23:57 +0200, Matúš Kukan wrote:
> 4. This is not problem for me, but in sal/inc/sal/cppunit.h I have
> seen typo: LibreOfficeProtect*e*r. So, it is unused,
> and I'm just wondering where and how it should be used ? It is
> something new ?
Fixed now.
I tweaked some existi
On Aug 28, 2011, at 11:57 PM, Matúš Kukan wrote:
> I was working on gbuildizing sal and few problems showed up:
>
> 1, in sal/osl/unx/system.h:75 there is #if GLIBC >= 2
>but I could not find how is GLIBC defined. In Env.Host.sh I have
> GLIBC="2REDHAT60" but that is something else probably.
>
Hi,
I was working on gbuildizing sal and few problems showed up:
1, in sal/osl/unx/system.h:75 there is #if GLIBC >= 2
but I could not find how is GLIBC defined. In Env.Host.sh I have
GLIBC="2REDHAT60" but that is something else probably.
(wrong branch in #if .. #else .. is executed for m
