Re: [Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

2011-09-14 Thread Stephan Bergmann
On 09/14/2011 08:47 PM, julien2412 wrote: Since I don't know the impact I prefer proposing a review. Of course, if you're really sure of you Eike (:-) ), I can commit and push right away on master http://nabble.documentfoundation.org/file/n3336763/patch_outdev3.txt patch_outdev3.txt Looking at

Re: [Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

2011-09-14 Thread julien2412
Hello, Since I don't know the impact I prefer proposing a review. Of course, if you're really sure of you Eike (:-) ), I can commit and push right away on master http://nabble.documentfoundation.org/file/n3336763/patch_outdev3.txt patch_outdev3.txt Julien. -- View this message in context: htt

Re: [Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

2011-09-13 Thread Eike Rathke
Hi julien2412, On Tuesday, 2011-09-13 13:03:41 -0700, julien2412 wrote: > Here's another "duplicateif" detected by cppcheck (thanks to Jesse's report > ;-) )in vcl/source/gdi/outdev3.cxx (line 1999) : > if( nMatchType & IMPL_FONT_ATTR_OTHERSTYLE ) > { > if( !(nMatchTyp

[Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

2011-09-13 Thread julien2412
Hello, Here's another "duplicateif" detected by cppcheck (thanks to Jesse's report ;-) )in vcl/source/gdi/outdev3.cxx (line 1999) : if( nMatchType & IMPL_FONT_ATTR_OTHERSTYLE ) { if( !(nMatchType & IMPL_FONT_ATTR_OTHERSTYLE) ) nTestMatch -= 1;