Re: [Libreoffice] curiosity in OResultSet.cxx

2011-08-08 Thread Terrence Enger
On Mon, 2011-08-08 at 15:10 +0100, Caolán McNamara wrote: > On Sat, 2011-08-06 at 14:01 -0400, Terrence Enger wrote: > > Do you know what I might be able to do to make LibreOffice > > execute the line in question? The queries I tried did not > > execute the line, and I confess that I did not persi

Re: [Libreoffice] curiosity in OResultSet.cxx

2011-08-08 Thread Caolán McNamara
On Sat, 2011-08-06 at 14:01 -0400, Terrence Enger wrote: > Do you know what I might be able to do to make LibreOffice > execute the line in question? The queries I tried did not > execute the line, and I confess that I did not persist very > long exploring in opengrok. Given that our default allo

Re: [Libreoffice] curiosity in OResultSet.cxx

2011-08-06 Thread Terrence Enger
On Fri, 2011-08-05 at 16:03 +0100, Caolán McNamara wrote: > On Fri, 2011-07-29 at 17:00 +0100, Caolán McNamara wrote: > > (snip) > > nah, the delete in OResultSet::setFetchSize is just bogus IMO and should > > be delete[]. Your discovery, send in the obvious patch for glory. > > Fair enough, patch

Re: [Libreoffice] curiosity in OResultSet.cxx

2011-08-05 Thread Caolán McNamara
On Fri, 2011-07-29 at 17:00 +0100, Caolán McNamara wrote: > On Fri, 2011-07-29 at 11:21 -0400, Terrence Enger wrote: > > libs-core/connectivity/source/drivers/odbcbase/OResultSet.cxx > > has a line which raises my suspicions. > > > Is the scalar delete really intended? If so, it might be > > wort

Re: [Libreoffice] curiosity in OResultSet.cxx

2011-07-29 Thread Caolán McNamara
On Fri, 2011-07-29 at 11:21 -0400, Terrence Enger wrote: > libs-core/connectivity/source/drivers/odbcbase/OResultSet.cxx > has a line which raises my suspicions. > Is the scalar delete really intended? If so, it might be > worth a comment just to humour paranoids like me. nah, the delete in ORes

[Libreoffice] curiosity in OResultSet.cxx

2011-07-29 Thread Terrence Enger
libs-core/connectivity/source/drivers/odbcbase/OResultSet.cxx has a line which raises my suspicions. Looking for references to m_pRowStatusArray, I see (*) two instances of array new, (*) one instance of array delete, and (*) an instance of scalar delete in OResultSet::setFetchSize(sal_Int32)