Re: [Libreoffice] automagic 'fix' in pre-commit hook considered harmful

2011-06-22 Thread Bjoern Michaelsen
On Wed, 22 Jun 2011 09:23:48 -0500 Norbert Thiebaud wrote: > Never-the-less I still think it is a 'Bad Thing(tm)' to have a > pre-commit hook altering on the fly what need to be committed... so I > suggest we stick with the 'warn but do no harm' approach (rather than > merely fixing/reverting the

Re: [Libreoffice] automagic 'fix' in pre-commit hook considered harmful

2011-06-22 Thread Norbert Thiebaud
On Wed, Jun 22, 2011 at 4:31 AM, Tor Lillqvist wrote: On 2011-06-22 at 10:16, wrote: >> Sure enough: do 2 changes in a file, in 2 separate hunk. in one of >> these change add trailing spaces... then commit only that hunk -> the >> second hunk 'disappear' > > The problem that I have noticed i

Re: [Libreoffice] automagic 'fix' in pre-commit hook considered harmful

2011-06-22 Thread Tor Lillqvist
>>> On 2011-06-22 at 10:16, wrote: > Sure enough: do 2 changes in a file, in 2 separate hunk. in one of > these change add trailing spaces... then commit only that hunk -> the > second hunk 'disappear' The problem that I have noticed is when having changes to several files, but committing just s

[Libreoffice] automagic 'fix' in pre-commit hook considered harmful

2011-06-22 Thread Norbert Thiebaud
A 'git' bug has been reported some times ago by Tor Lillqvist. the symptom was that on a partial commit the rest of the changes (the uncommited part') would 'disappear'. Unfortunately the condition to reproduce that problem eluded us... While reviewing the EasyHack list, I noticed one about the p