Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-09 Thread Bjoern Michaelsen
On Sat, Dec 10, 2011 at 01:08:30AM +0100, Jan Holesovsky wrote: > ifeq($(OS),WNT) > something $(shell cygpath -m $(OUTDIR)/ugh) > else > something $(OUTDIR)/ugh > endif > > which makes the buildsystem overall ugly ;-) Well, there is this dark piece of voodoo called gb_Helper_abbrevia

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-09 Thread Jan Holesovsky
Hi Bjoern, On 2011-12-05 at 12:42 +0100, Bjoern Michaelsen wrote: > Well, there is a good reason for paths in GNU make to be unix-paths. You > define > a rule as: > > C:B > true > > for target C depending on B. If you use windows native paths something like: > > C:B:D > true > > is v

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-05 Thread Bjoern Michaelsen
Hi Kendy, all, On Mon, Dec 05, 2011 at 02:03:11AM +0100, Jan Holesovsky wrote: > In the end, I worked that around using this: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f259162cf511528c210eb71f51e63b5ff6838ff5 > > I still believe the rewriting of the OUTDIR & friends in BuildDir

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-04 Thread Jan Holesovsky
Hi Bjoern, Bjoern Michaelsen píše v Čt 01. 12. 2011 v 09:21 +0100: > > And reverting > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 > > fixes it. I haven't pushed the revert yet since I don't know the > > intent of this commit. > > Please pu

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-04 Thread Jan Holesovsky
Hi, Jan Holesovsky píše v Ne 04. 12. 2011 v 11:44 +0100: > > If we want beta1 to be better than beta0, we can't require > > people having to make clean after each edit, and rebuild from scratch > > (effectively making the fix-test-commit cycle take one day). > > Then again - if we want to have b

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-04 Thread Jan Holesovsky
Hi Kohei, Tor, Tor Lillqvist píše v So 03. 12. 2011 v 12:56 +0200: > > Kendy (this time CC'd), please don't commit this stuff. It breaks > > incremental build on Windows, making debugging Windows impossible. > > Hear, hear. If we want beta1 to be better than beta0, we can't require > people hav

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-04 Thread Jan Holesovsky
Hi Kohei, Tor, Tor Lillqvist píše v So 03. 12. 2011 v 12:56 +0200: > > Kendy (this time CC'd), please don't commit this stuff. It breaks > > incremental build on Windows, making debugging Windows impossible. > > Hear, hear. If we want beta1 to be better than beta0, we can't require > people hav

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-03 Thread Tor Lillqvist
> Kendy (this time CC'd), please don't commit this stuff.  It breaks > incremental build on Windows, making debugging Windows impossible. Hear, hear. If we want beta1 to be better than beta0, we can't require people having to make clean after each edit, and rebuild from scratch (effectively making

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-02 Thread Kohei Yoshida
On Thu, Dec 1, 2011 at 9:12 AM, Kohei Yoshida wrote: > Hi Bjoern, > > On Thu, 2011-12-01 at 09:21 +0100, Bjoern Michaelsen wrote: >> On Thu, Dec 01, 2011 at 01:36:14AM -0500, Kohei Yoshida wrote: >> > And reverting >> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d7

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-01 Thread Kohei Yoshida
Hi Bjoern, On Thu, 2011-12-01 at 09:21 +0100, Bjoern Michaelsen wrote: > On Thu, Dec 01, 2011 at 01:36:14AM -0500, Kohei Yoshida wrote: > > And reverting > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 > > fixes it. I haven't pushed the revert

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-01 Thread Bjoern Michaelsen
On Thu, Dec 01, 2011 at 01:36:14AM -0500, Kohei Yoshida wrote: > And reverting > http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 > fixes it. I haven't pushed the revert yet since I don't know the > intent of this commit. Please push, the commit was

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-11-30 Thread Kohei Yoshida
On Thu, Dec 1, 2011 at 1:17 AM, Kohei Yoshida wrote: > Hi there, > > Windows build is broken once again, And reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 fixes it. I haven't pushed the revert yet since I don't know the intent of thi

[Libreoffice] Windows (MSVC) incremental build is broken.

2011-11-30 Thread Kohei Yoshida
Hi there, Windows build is broken once again, and this time it fails during incremental build only. After a full build succeeds, Doing e.g. source Env.Host.sh cd sc make fails 100% of the time. It doesn't matter which module you are in, or which file you touch. It always fails. However, goi