Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-16 Thread Jonas Finnemann Jensen
Hi Luke, Here's the redo of this patch :) Cool, pushed... :) This is a nice step towards getting it stable... If you like searching code and guessing what might be the right solution, copy/paste integration could be next... By the way, let me know if you've any ideas on how formatting should wo

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-15 Thread Luke Dixon
Hi Jonas, On Tue, 2011-02-15 at 21:51 +0100, Jonas Finnemann Jensen wrote: > Well, lets just think about writing a note for the next guy, if we > find a solution :) I suppose the EditEngine::SetText functions would be be a good place to start. > > I noticed that 0x is used in Selec

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-15 Thread Jonas Finnemann Jensen
Hi Luke, Would be cool, would be a bit difficult to document it when I don't know > what it's supposed to be doing though. That isn't an excuse though, I > don't mind trying to work out a few of them. Well, lets just think about writing a note for the next guy, if we find a solution :) pDocSh

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-14 Thread Luke Dixon
Hi Jonas, On Mon, 2011-02-14 at 20:17 +0100, Jonas Finnemann Jensen wrote: > > I think it ought to be that easy... More documentation would speedup > development and reduce bugs dramatically... > (Maybe we should write a few doxygen comments for EditEngine, if we > figure out how it work

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-14 Thread Jonas Finnemann Jensen
hi Luke, I should have known better than to think it was that easy. :) I think it ought to be that easy... More documentation would speedup development and reduce bugs dramatically... (Maybe we should write a few doxygen comments for EditEngine, if we figure out how it works). I had a very bad s

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Luke Dixon
Hi Jonas, On Sun, 2011-02-13 at 21:44 +0100, Jonas Finnemann Jensen wrote: > It would be major step to get that issue fixed... And you're going the > right way, but your patch doesn't work if the formula is written in > multiple lines... > try, writing the formula 3+3+3 \n \n \n \n +4+4 (replace

Re: [Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Jonas Finnemann Jensen
Hi Luke, It seems that undo/redo is the major one and I just worked out why > undo/redo wasn't working, noticed it while looking at Caolán's unit > tests for starmath. I've attached the patch. It would be major step to get that issue fixed... And you're going the right way, but your patch doesn't

[Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

2011-02-13 Thread Luke Dixon
Hi Michael, Jonas, On Fri, 2011-02-11 at 10:15 +, Michael Meeks wrote: > Quick question, while I'm here: what are the blockers for enabling this > by default on master ? was it undo/redo ? or do we have any malingering > known crashers / mis-features left. I think Jonas fixed the crash