Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-16 Thread Korrawit Pruegsanusak
Hello Tim, Kohei, * On Mon, Jan 16, 2012 at 01:26, Kohei Yoshida wrote: > Calc uses rtl::math::round from sal module (in sal/inc/rtl/math.hxx). > My suggestion is to stick with that one instead of introducing another > OS independent round function. Thanks! :-) I just push a fix. http://cgit.fre

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Kohei Yoshida
Hi there, On Sun, Jan 15, 2012 at 1:04 PM, Tim Hardeck wrote: > But if ::boost::math::iround will be used in other places or if there is > already another usable round function - what does Calc use? Calc uses rtl::math::round from sal module (in sal/inc/rtl/math.hxx). My suggestion is to stick

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Tim Hardeck
Hi Korrawit, thanks for testing and your hints how to address the problem. The reason why I was using round was to reduce the difference between the positions while scrolling in one direction and then back. With round it takes more steps to reach a position where they will differ slightly. Sinc

[Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Korrawit Pruegsanusak
Hello Tim, all, Your patch addressing fdo#44173 regarding zoom level [1] cause the windows msvc tinderbox failure. [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=022ce7d362f146ed69f54aae20cf2b8c582e9f8d Actually, the one to blame is the msvc library, because it doesn't have round()