Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-03 Thread Suren
Hi Thorsten, On 12/03/2010 10:03 PM, Thorsten Behrens wrote: Hi Suren, so, just pushed your patches to master - added two tweaks: * FileChangedChecker moved out to svtools/source/misc/filechangedchecker.cxx * and to make it not rely on writer internals, using a generic callback mechanism

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-03 Thread Thorsten Behrens
surensp...@gmail.com wrote: > I shall touch base with you on the IRC and will implement all the > tweaks as you suggest. If there are any best practices wiki link, > please guide me to that :) > > > There are one or two other things that could benefit from looking > > into, e.g. the usage of the w

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-02 Thread surensp...@gmail.com
Hey Thorsten , On Thu, Dec 2, 2010 at 1:05 PM, Thorsten Behrens wrote: > > I had initially intended to reply even earlier, was playing with > your patch yesterday - sadly, there was much preemption. So here's a > little intermezzo - great work so far, stuff looks promising! I understand. There h

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-01 Thread Thorsten Behrens
surensp...@gmail.com wrote: > After few sleepless nights spent grokking and with quite a big deal > help from IRC and the list, have come up with the first cuts working > version of the External Edit functionality[1]. Have attached the > patches rebased against the latest master. > Hi Suren, I had

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-30 Thread surensp...@gmail.com
Hi everyone, After few sleepless nights spent grokking and with quite a big deal help from IRC and the list, have come up with the first cuts working version of the External Edit functionality[1]. Have attached the patches rebased against the latest master. Would love to hear reviews/suggestions/i

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-22 Thread Michael Meeks
Hi there, On Mon, 2010-11-22 at 10:50 +0530, surensp...@gmail.com wrote: > Here are the few alternatives I can think of : > 1) register an event Listener to listen to any change of that > temporary file. And update the graphic in the call-back function of > that event listener. Remove the event li

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-21 Thread surensp...@gmail.com
Hi Thorsten, Mon, Nov 15, 2010 at 5:40 PM, Thorsten Behrens wrote: > surensp...@gmail.com wrote: >> 1) Making it work in all OS/platforms: >> [...] >> > Hi Suren, > > wow, great progress! For the editing, one easy way out would be to > use the SystemShellExecute service, which will pick an app >

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-15 Thread Thorsten Behrens
surensp...@gmail.com wrote: > 1) Making it work in all OS/platforms: > [...] > Hi Suren, wow, great progress! For the editing, one easy way out would be to use the SystemShellExecute service, which will pick an app registered for the file type at hand. You can e.g. find a usage example in sfx2/sou

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-14 Thread surensp...@gmail.com
Apologies for the blank mail earlier. Accidentally hit the send button :( -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-14 Thread surensp...@gmail.com
Hi Thorsten, First of all, Many thanks for all the help through out :) I have attached the patches ( I have re-based with the latest origin/master as of Sunday Night IST ) for the First cuts of the "Edit with External Application" functionality. I have seen it working nicely in Gnome based (just

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-14 Thread surensp...@gmail.com
On Sat, Nov 13, 2010 at 4:57 AM, Thorsten Behrens wrote: > surensp...@gmail.com wrote: >> 2) The thread is not blocking as expected when osl_ExecuteProcess is >> called and since it does not block, no other threads get executed. So >> back to the problem of LO window hanging up. Probably I am usin

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-12 Thread Thorsten Behrens
surensp...@gmail.com wrote: > 2) The thread is not blocking as expected when osl_ExecuteProcess is > called and since it does not block, no other threads get executed. So > back to the problem of LO window hanging up. Probably I am using a > wrong osl_ProcessOption ? > Hi Suren, meh, that's my ba

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-12 Thread surensp...@gmail.com
Hi Thorsten, > It Did, It did. When I Hit compile and when it worked I was litreally > jumping in my seat. :) Will clean up code and submit the patch soon > enough. Thanks for the help very much :) > I have attached the new snippet I have come up with. There are few issues I faced. 1) The postUs

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-10 Thread surensp...@gmail.com
Hi Thorsten, On Wed, Nov 10, 2010 at 10:32 PM, Thorsten Behrens wrote: >> > Hi Suren, > > since you already create a separate thread for the editing - just > fire it off, and send the main app a msg - like here: > > desktop/source/app/officeipcthread.cxx:289 > > (you'll probably replace STATIC_LI

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-10 Thread Thorsten Behrens
surensp...@gmail.com wrote: > I current way I am implementing is that I save the Graphic a temporary > file,then to create a new thread ( using osl_createThread from > osl/thread.h ) and from within the new thread execute the external > application to open the temp ( using osl_executeProcess from >

[Libreoffice] Suggestion needed for External Edit functionality.

2010-11-10 Thread surensp...@gmail.com
Hi Everyone, This is regarding this bug - https://bugs.freedesktop.org/show_bug.cgi?id=30508 Goal: To be able to open an image(Graphic item) in an external application for advanced editing What is already done: Added a menu item to right click popup on the graphic, coupled the menu item with a me