Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-03 Thread Francois Tigeot
On Tue, May 03, 2011 at 10:21:18AM +0200, Francois Tigeot wrote: > On Tue, May 03, 2011 at 02:06:24AM -0600, Tor Lillqvist wrote: > > > I mean, if we have code in there that assumes NTFS (and SMB) volumes are > > case insensitive (at least when accessed from Windows), we should > > definitely ke

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-03 Thread Francois Tigeot
On Tue, May 03, 2011 at 02:06:24AM -0600, Tor Lillqvist wrote: > > And this would also be stupid: only the WIN32 subsystem > > Which is the subsystem LibreOffice runs in, so what is your point? NTFS itself is case sensitive. There may be files files differing only by case even on Microsoft Window

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-03 Thread Tor Lillqvist
> And this would also be stupid: only the WIN32 subsystem Which is the subsystem LibreOffice runs in, so what is your point? > is case-insensitive > by default on Windows NT systems. And it can be set to be case-sensitive > by toggling a single registry value. Surely you are not suggesting we sh

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-02 Thread Francois Tigeot
On Mon, May 02, 2011 at 08:45:46PM +0200, Francois Tigeot wrote: > > A little part may be useful after all: some functions use knowledge of the > file system to determine if file names are case sensitive or not. > > I don't know enough about this matter to decide what to do yet. Maybe I > should

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-02 Thread Francois Tigeot
On Mon, May 02, 2011 at 06:18:04PM +0200, Thorsten Behrens wrote: > Francois Tigeot wrote: > > Is there a reasonable explanation for the existence of this enum or am I > > free > > to rip it out and clean all the code using it ? > > > Rip it out, with the usual due diligence - chances are that yo

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-02 Thread Thorsten Behrens
Francois Tigeot wrote: > Is there a reasonable explanation for the existence of this enum or am I free > to rip it out and clean all the code using it ? > Rip it out, with the usual due diligence - chances are that you'll find 1-2 places that *are* still used (in error) today ... ;) Cheers, -- T

Re: [Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-02 Thread Thorsten Behrens
Francois Tigeot wrote: > Is there a reasonable explanation for the existence of this enum or am I free > to rip it out and clean all the code using it ? > Rip it out, with the usual due diligence - chances are that you'll find 1-2 places that *are* still used (in error) today ... ;) Cheers, -- T

[Libreoffice] Strange filesystems-related enum in libs-gui/tools

2011-05-01 Thread Francois Tigeot
Hi, libs-gui/tools/inc/tools/fsys.hxx defines a FSysPathStyle enum, which is used by different files in libs-gui/tools/source/fsys/ This enum contains names which are related to different filesystem or filesystem/operating system combinations (most of them obsolete) like FSYS_STYLE_MSDOS, FSYS_ST