Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-08 Thread Caolán McNamara
On Mon, 2011-08-08 at 11:56 +0200, Stephan Bergmann wrote: > one could even imagine locking a mutex around dlopen/dlerror in > osl_loadModule, so that at least all non-third-party-calls to > dlopen/dlerror cooperate for correct multi-threaded behavior. But > that would probably be overkill.) I

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-08 Thread Stephan Bergmann
On Aug 4, 2011, at 1:04 PM, Lubos Lunak wrote: > On Wednesday 03 of August 2011, Caolán McNamara wrote: >> On Tue, 2011-08-02 at 14:58 +0200, Lubos Lunak wrote: >>> - osl_loadModule*() functions are plain C functions from stable API, so >>> no overloading to add the extra argument for the error mes

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-04 Thread Lubos Lunak
On Wednesday 03 of August 2011, Caolán McNamara wrote: > On Tue, 2011-08-02 at 14:58 +0200, Lubos Lunak wrote: > > - osl_loadModule*() functions are plain C functions from stable API, so > > no overloading to add the extra argument for the error message, the best > > I've come up with was simply a

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-04 Thread Lubos Lunak
On Wednesday 03 of August 2011, Noel Power wrote: > On 03/08/11 11:08, Noel Power wrote: > > ( /me must remember to reply-all ) Decent mailers have 'Reply-To-List' :). > > hmm I think it would be nicer to handle at least the > > CannotActivateFactoryException problems from the filter instatiatio

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-03 Thread Noel Power
On 03/08/11 11:08, Noel Power wrote: ( /me must remember to reply-all ) Hi Lubos On 02/08/11 13:58, Lubos Lunak wrote: Hello, last week .docx support was broken because of a mistake during the gbuild changes and I wasted quite some time finding out what was wrong. As something similar ha

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-03 Thread Caolán McNamara
On Tue, 2011-08-02 at 14:58 +0200, Lubos Lunak wrote: > - osl_loadModule*() functions are plain C functions from stable API, so no > overloading to add the extra argument for the error message, the best I've > come up with was simply a wrapper around dlerror(), which I admit is not very > nice A

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-03 Thread Noel Power
( /me must remember to reply-all ) Hi Lubos On 02/08/11 13:58, Lubos Lunak wrote: Hello, last week .docx support was broken because of a mistake during the gbuild changes and I wasted quite some time finding out what was wrong. As something similar had happened to me already same for me ( t

[Libreoffice] Reporting an error when loading of a component fails

2011-08-02 Thread Lubos Lunak
Hello, last week .docx support was broken because of a mistake during the gbuild changes and I wasted quite some time finding out what was wrong. As something similar had happened to me already before I'd like to apply the attached patches. However I have some issues with it: - the error di