Re: [Libreoffice] RTL_CONSTASCII_STRINGPARAM vs RTL_CONSTASCII_USTRINGPARAM

2010-11-16 Thread Michael Meeks
On Sun, 2010-11-14 at 12:47 +, Caolán McNamara wrote: > Michael mentioned to me that he had seen cases where .. > I should note that none of these errors are new or have been introduced > recently, but have been lurking in the code for quite a while. .. > I've already found quite a few problem

[Libreoffice] RTL_CONSTASCII_STRINGPARAM vs RTL_CONSTASCII_USTRINGPARAM and String/UniString

2010-11-14 Thread Caolán McNamara
Michael mentioned to me that he had seen cases where "RTL_CONSTASCII_STRINGPARAM" was accidentally used instead of "RTL_CONSTASCII_USTRINGPARAM". Here's the problem... #define RTL_CONSTASCII_STRINGPARAM( constAsciiStr ) constAsciiStr, ((sal_Int32)sizeof(constAsciiStr)-1) which turns into two #de

[Libreoffice] RTL_CONSTASCII_STRINGPARAM vs RTL_CONSTASCII_USTRINGPARAM

2010-11-14 Thread Caolán McNamara
Michael mentioned to me that he had seen cases where "RTL_CONSTASCII_STRINGPARAM" was accidentally used instead of "RTL_CONSTASCII_USTRINGPARAM" #define RTL_CONSTASCII_STRINGPARAM( constAsciiStr ) constAsciiStr, ((sal_Int32)sizeof(constAsciiStr)-1) #define RTL_CONSTASCII_USTRINGPARAM( constAscii