[Libreoffice] PUSHED][PATCH] migrate to StringRangeEnumerator in Draw

2011-10-04 Thread Caolán McNamara
On Tue, 2011-10-04 at 17:50 +0400, Ivan Timofeev wrote: > oops, I've said "+ 1", but wrote "- 1" to patch. I'm sorry. no problem, pushed for you now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [PUSHED][PATCH] migrate to StringRangeEnumerator in Draw

2011-10-04 Thread Ivan Timofeev
oops, I've said "+ 1", but wrote "- 1" to patch. I'm sorry. From 754322a700c43d84f3c17926dd5d993a08f46ee3 Mon Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Tue, 4 Oct 2011 17:16:34 +0400 Subject: [PATCH] fix doubling of one page when range is empty and incorrect selection page --- sd/source/ui

Re: [Libreoffice] [PUSHED][PATCH] migrate to StringRangeEnumerator in Draw

2011-10-04 Thread Ivan Timofeev
Hello, my previous patch introduced some bugs. :-) 1. If doc contains the only one page and range is empty, this page doubles. I think, this is due to errors in StringRangeEnumerator. 2. Current page index is zero-based in code and one-based in UI. So, I've added "+1". From d4ed0f5f1cc5e34fdad1cfd

[Libreoffice] [PUSHED][PATCH] migrate to StringRangeEnumerator in Draw

2011-10-03 Thread Caolán McNamara
On Sun, 2011-10-02 at 23:23 +0400, Ivan Timofeev wrote: > This patches replace MultiSelection with StringRangeEnumerator in > Draw, because StringRangeEnumerator allows duplicated and reversed > ranges, i.e. "1,1,3-1". Second patch contains only cleaning changes. All looks good to me anyway, pushe