Re: [Libreoffice] Mutex(Guard) ignores failure to create/acquire Mutex

2011-08-19 Thread Tor Lillqvist
> EnterCriticalSection does not return a value... it is recursive but > the doc does not mention any limit (and since Windows is not open > source, I cannot go and look in the source code to find out what the > limit is) Well, if you just look at the definition of CRITICAL_SECTION in winbase.h (fo

Re: [Libreoffice] Mutex(Guard) ignores failure to create/acquire Mutex

2011-08-18 Thread Noel Grandin
Perhaps it would be a good idea to add some comments to that code so that analysis is preserving for future generations of code archeologists :-) Seriously, I often do this because it saves me time later when I look at some code and think "why is it doing _that__???" Michael Meeks wrote: > On T

Re: [Libreoffice] Mutex(Guard) ignores failure to create/acquire Mutex

2011-08-18 Thread Michael Meeks
On Thu, 2011-08-18 at 01:57 -0500, Norbert Thiebaud wrote: > Guards are used and badly abused in the code, especially with the > infamous SolarMutex... > anything that would make that code slower or fatter than it already is > (with virtual functions and all), especially for corner-case > 'you-are

Re: [Libreoffice] Mutex(Guard) ignores failure to create/acquire Mutex

2011-08-17 Thread Norbert Thiebaud
On Thu, Aug 18, 2011 at 12:12 AM, Lionel Elie Mamane wrote: > Hi, > > I noticed that Mutex(Guard) C++ helper classes silently ignores > failures to create / acquire / release / destroy a mutex, which seems > rather worrying: if one puts a mutex acquire, it means the rest of the > code should not e

[Libreoffice] Mutex(Guard) ignores failure to create/acquire Mutex

2011-08-17 Thread Lionel Elie Mamane
Hi, I noticed that Mutex(Guard) C++ helper classes silently ignores failures to create / acquire / release / destroy a mutex, which seems rather worrying: if one puts a mutex acquire, it means the rest of the code should not execute if the mutex was not acquired, lest subtle bugs crop up (corrupti