Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Lubos Lunak
On Friday 27 of January 2012, Muthu Subramanian K wrote: > Hello Alexander, > > Its nice to see those patches. But, it will be nice to see/use the > tools/scripts directly? Especially if they can be hooked to git (like > the current white space/tabs removal ones)? Are you seriously suggesting tha

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Michael Meeks
On Fri, 2012-01-27 at 16:42 +0530, Muthu Subramanian K wrote: > Yes, I very well agree with this - I have faced problems with the > history before. But, I was actually referring to specifically the git > hooks - which might be helpful in catching typos? Mea culpa; I should have read your

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Muthu Subramanian K
> So - -really- I'm less convinced of that. As I said - this busts our > history. Yes, I very well agree with this - I have faced problems with the history before. But, I was actually referring to specifically the git hooks - which might be helpful in catching typos? > > So - as I sai

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Alexander Bergmann
Hi Muthu, Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? First I noticed, that ( () ) did only appear in two cases: SAL_THROW( () ) and THROWS( () ) As I wan

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Michael Meeks
On Fri, 2012-01-27 at 10:19 +0530, Muthu Subramanian K wrote: > Its nice to see those patches. But, it will be nice to see/use the > tools/scripts directly So - -really- I'm less convinced of that. As I said - this busts our history. It is true that we did a big whitespace cleanu

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Stephan Bergmann
On 01/27/2012 07:54 AM, Ivan Timofeev wrote: ... but we have no strong rule about this kind of formatting. The "Code Conventions" page[1] we refer to in our Development wiki page[2] contains nothing about foo( bar ); vs foo(bar); vs foo (bar); Personally I prefer the second variant, but usually

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Stephan Bergmann
On 01/27/2012 05:49 AM, Muthu Subramanian K wrote: Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? @lubos: Alexander is good with scripts, so as a starter he wante

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Ivan Timofeev
27.01.2012 08:55, Muthu Subramanian K пишет: @Alex: Forgot to mention one more thing: We follow (normally) space after '(' and before ')' if there are parameters. Sometimes, we would be tempted to remove the space in cases like foo( param1, param2 ); as well ;) ( I am always tempted in such cases

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Muthu Subramanian K
@Alex: Forgot to mention one more thing: We follow (normally) space after '(' and before ')' if there are parameters. Sometimes, we would be tempted to remove the space in cases like foo( param1, param2 ); as well ;) ( I am always tempted in such cases :P ) On 01/27/2012 10:19 AM, Muthu Subramania

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-26 Thread Muthu Subramanian K
Hello Alexander, Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? @lubos: Alexander is good with scripts, so as a starter he wanted to do something like "http://cgit