Re: [Libreoffice] Help fixing ImplHandleInputLangChange implementation

2011-06-20 Thread Jesús Corrius
>        It can help debugging if methods always return from the same place; but > then it can help code readability if it is not incredibly deeply > indented. I am from the "code readability" school of programing :) > >> Thanks for the help! :) > >        Sorry for not helping :-) just do what y

Re: [Libreoffice] Help fixing ImplHandleInputLangChange implementation

2011-06-20 Thread Michael Meeks
Hi Jesus, On Mon, 2011-06-20 at 20:47 +0200, Jesús Corrius wrote: > What's the preferred way to fix it? :-) > a) put everything in an if (pFrame) {} block > b) if(!pFrame) return; It can help debugging if methods always return from the same place; but then it can help code r

[Libreoffice] Help fixing ImplHandleInputLangChange implementation

2011-06-20 Thread Jesús Corrius
Hi all, I'd like to fix this function implementation, as it makes my eyes cry ;) Notice that if pFrame == NULL, the function will crash anyway because it's only checked in the first if block and later is dereferenced. static void ImplHandleInputLangChange( HWND hWnd, WPARAM, LPARAM lParam ) {