Re: [Libreoffice] Helgrind results for LO

2011-04-08 Thread Michael Meeks
On Wed, 2011-04-06 at 11:42 +0100, Caolán McNamara wrote: > On Mon, 2011-04-04 at 11:39 +0100, Caolán McNamara wrote: > > I've got visibility enabled in my desktop env and so a goodly chunk of > > the /memcheck/ warnings are in the gnome a11y stack, something which I've > > always some dubious fee

[Libreoffice] Helgrind results for LO

2011-04-08 Thread Julian Seward
At FOSDEM'11 there was some mumbling about LO's regression tests taking two days to run due to some timeout kludgery necessitated by occasional hangs at exit due to possible threading bugs. Or something like that. I can't remember exactly. Recently I've been improving Valgrind's Helgrind tool a

Re: [Libreoffice] Helgrind results for LO

2011-04-06 Thread Julian Seward
> gtk a11y stack, while the initial helgrind ones end on in gdbusprivate.c > etc. The reports of races are not going to be accurate unless Helgrind sees all the sync events done by the lower level libraries. If they just use the pthread_ primitives that's fine, but if they roll their own locks e

Re: [Libreoffice] Helgrind results for LO

2011-03-31 Thread Caolán McNamara
On Thu, 2011-03-31 at 20:58 +0200, Julian Seward wrote: > On Thursday, March 31, 2011, Caolán McNamara wrote: > > The first one at least seems to be the common enough pattern we have > > where we grab our global mutex when initializing singletons on first > > use/creation > > > > so we have loads

Re: [Libreoffice] Helgrind results for LO

2011-03-31 Thread Julian Seward
On Thursday, March 31, 2011, Caolán McNamara wrote: > The first one at least seems to be the common enough pattern we have > where we grab our global mutex when initializing singletons on first > use/creation e.g. > > const Class& foo() > { > static Class aFoo; > if (aFoo.uninit) //ne

Re: [Libreoffice] Helgrind results for LO

2011-03-31 Thread Caolán McNamara
On Thu, 2011-03-31 at 14:00 +0200, Julian Seward wrote: > Surely some part of LO uses threadsafe refcounted classes? There's the common thread-safe shared ownership rtl_uString string, etc. e.g. sal/rtl/source/strtmpl.c and the use of thread-safe osl_incrementInterlockedCount/osl_decrementInterloc

[Libreoffice] Helgrind results for LO

2011-03-31 Thread Julian Seward
At FOSDEM'11 there was some mumbling about LO's regression tests taking two days to run due to some timeout kludgery necessitated by occasional hangs at exit due to possible threading bugs. Or something like that. I can't remember exactly. Recently I've been improving Valgrind's Helgrind tool a