Re: [Libreoffice] Doubt about bogus and commented code

2011-03-17 Thread Jan Holesovsky
Hi Xisco, On 2011-03-17 at 13:52 +0100, Xisco Faulí wrote: > // #FIXME this *MUST* be wrong documents::close surely closes ALL > documents > // in the collection, use of getCurrentDocument here is totally wrong > -/* > - uno::Reference< lang::XMultiComponentFactory > xSMgr( > - mxContext->getServ

Re: [Libreoffice] Doubt about bogus and commented code

2011-03-17 Thread Xisco Faulí
// #FIXME this *MUST* be wrong documents::close surely closes ALL documents // in the collection, use of getCurrentDocument here is totally wrong -/* - uno::Reference< lang::XMultiComponentFactory > xSMgr( - mxContext->getServiceManager(), uno::UNO_QUERY_THROW ); - uno::Reference< frame::XModel >

Re: [Libreoffice] Doubt about bogus and commented code

2011-03-17 Thread Jan Holesovsky
Hi Xisco, On 2011-03-12 at 02:25 +0100, Xisco Faulí wrote: > I've seen quite often something like this: > > -/* > - #i2345# > - if ( nSlotId >= SID_SFX_START && ! > SfxMenuManager::IsPopupFunction(nSlotId) ) > - { > - // Echte Popups sollen keine SlotIds haben; leider sind > - // da noch Altlast

[Libreoffice] Doubt about bogus and commented code

2011-03-11 Thread Xisco Faulí
Hello there, I've seen quite often something like this: -/* - #i2345# - if ( nSlotId >= SID_SFX_START && !SfxMenuManager::IsPopupFunction(nSlotId) ) - { - // Echte Popups sollen keine SlotIds haben; leider sind - // da noch Altlasten mit herumzuschleppen ... - String aTitle = pSVMenu->GetItemText