[Libreoffice] DECLARE_LIST removal fallout, was: Review request: [PUSHED] http://pastebin.com/bgVxQKug

2011-05-12 Thread Tor Lillqvist
This has now been pushed. (Commit: http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id=746fff15ad34616635e09125f6d0656da39a05ad ) But in general, this bug, and I guess similar ones Michael was investigating recently, brings up a serious question: How broken might the cod

Re: [Libreoffice] DECLARE_LIST() Removal Project

2011-02-22 Thread Rafael Dominguez
On Tue, Feb 22, 2011 at 1:35 PM, Jan Holesovsky wrote: > Hi Joseph, > > On 2011-02-20 at 20:40 -0800, Joseph Powers wrote: > > Here's a quick update on the project: > > > > 1. The only items left are: > > Very nice! :-) > > > 2. We also have a few locations where the "List" class is used > > dire

Re: [Libreoffice] DECLARE_LIST() Removal Project

2011-02-22 Thread Jan Holesovsky
Hi Joseph, On 2011-02-20 at 20:40 -0800, Joseph Powers wrote: > Here's a quick update on the project: > > 1. The only items left are: Very nice! :-) > 2. We also have a few locations where the "List" class is used > directly with out the DECLARE_LIST() macro. > > > My work order is: > > > 1.

Re: [Libreoffice] DECLARE_LIST() Removal Project

2011-02-21 Thread Rafael Dominguez
On Mon, Feb 21, 2011 at 12:10 AM, Joseph Powers wrote: > Here's a quick update on the project: > > 1. The only items left are: > > binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeConnections, > DdeConnection* ) > binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTransactions, > DdeTransacti

Re: [Libreoffice] DECLARE_LIST() Removal Project

2011-02-20 Thread Norbert Thiebaud
On Sun, Feb 20, 2011 at 10:40 PM, Joseph Powers wrote: > > PS: Rafeal, I pushed your patch to convert the std::vector to > boost::ptr_vector in writer.  Sorry I don't know how to preserve your > submitter information (my git foo is bad). I had one section that did not > apply cleanly so I had t

[Libreoffice] DECLARE_LIST() Removal Project

2011-02-20 Thread Joseph Powers
Here's a quick update on the project: 1. The only items left are: binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeConnections, DdeConnection* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTransactions, DdeTransaction* ) binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeFormats, lo

Re: [Libreoffice] DECLARE_LIST() Removal

2011-02-19 Thread Fridrich Strba
Hello, On Fri, 2011-02-18 at 20:32 -0800, Joseph Powers wrote: > I really liked your work on sw/source/ui/inc/swuicnttab.hxx and thank > you for your help. If you're building on a MS-Windows box it would be > nice if you could look at the ones flagged as "windows" above. It is ok, just to do the

[Libreoffice] DECLARE_LIST() Removal

2011-02-18 Thread Joseph Powers
Rafael, I believe we are almost done. The only ones I show as remaining are: binfilter/inc/bf_svtools/svdde.hxx DECLARE_LIST( DdeConnections, DdeConnection* ) windows binfilter/inc/bf_svtools/svdde.hxx DECLARE_LIST( DdeTransactions, DdeTransaction* )windows binfilter/inc/bf_s