Re: [Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread Michael Meeks
Hi Julien, On Sun, 2012-01-08 at 03:25 -0800, julien2412 wrote: > For the file desktop/unx/source/file_image_unx.c, cppcheck tells : > line 120 is : w.m_size -= w.m_size; > Either this is right and it could be simplified with w.m_size = 0 > or it's wrong and what should it be ? > (this time no ove

Re: [Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 12:25 PM, julien2412 wrote: For the file desktop/unx/source/file_image_unx.c, cppcheck tells : 120 duplicateExpression style Same expression on both sides of '-'. 93 unreadVariable style Variable 'c' is assigned a value that is never used line 93 is : volatile ch

[Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-08 Thread julien2412
Hello, For the file desktop/unx/source/file_image_unx.c, cppcheck tells : 120 duplicateExpression style Same expression on both sides of '-'. 93 unreadVariable style Variable 'c' is assigned a value that is never used line 93 is : volatile char c = 0 Should this variable just b