Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread Nigel Hawkins
Hi David, > 4. Special preprocessor magic is required... > > 5. sal tests are 'special' with regard to cppunit... Could you summarise this sort of information on the wiki somewhere? A lot of the code-base seems to have very little testing in place and dependency issues make it hard enough to ad

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread David Tardon
On Tue, Feb 08, 2011 at 09:16:54AM +0100, David Tardon wrote: > On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote: > > More reanimated tests. The osl/file part is not satisfying. I had to > > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to > > keep it. > > >

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread David Tardon
On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote: > More reanimated tests. The osl/file part is not satisfying. I had to > switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to > keep it. > > These patches are LGPLv3+/MPL. > Nice work! I have a couple of comment